search

linuxserver / docker-diskover

A Docker container for the Diskover space mapping application
GNU General Public License v3.0
76 stars 16 forks source link

Add php7-sqlite3 for rc4 #50

Closed martadinata666 closed 2 years ago

martadinata666 commented 2 years ago

linuxserver.io

Description:

Addded dependencies for diskover rc4, as rc4 will store user & pass to sqlite db

Benefits of this PR and context:

supporting rc4

References

https://github.com/diskoverdata/diskover-community/blob/master/diskover-web/CHANGELOG.md

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/diskover/v2.0-rc.4-pkg-3b195666-pr-50/index.html https://ci-tests.linuxserver.io/lspipepr/diskover/v2.0-rc.4-pkg-3b195666-pr-50/shellcheck-result.xml

serkef commented 2 years ago

Can we get this merged? Current release v2.0-rc.4-ls49 is unusable without this change. I just tested it and this changes solves the issue.

thespad commented 2 years ago

Please add a changelog note to the readme-vars and then I'm happy to merge this.

martadinata666 commented 2 years ago

dd.mm.yy right?

aptalca commented 2 years ago

yup

martadinata666 commented 2 years ago

thanks, anything still miss?

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/diskover/v2.0-rc.4-pkg-3b195666-pr-50/index.html https://ci-tests.linuxserver.io/lspipepr/diskover/v2.0-rc.4-pkg-3b195666-pr-50/shellcheck-result.xml

aptalca commented 2 years ago

thanks for the PR, it should push a new image in about 15 minutes or so