linuxserver / docker-dokuwiki

GNU General Public License v3.0
113 stars 24 forks source link

Finish off container and multiarch #3

Closed CHBMB closed 5 years ago

CHBMB commented 5 years ago

Had to make up some logic to grab the latest release from an RSS feed, so set Jenkins-vars to os but would appreciate a 2nd pair of eyes to check that will work.

Tested on x64 but armhf and arm64 tags here

thelamer commented 5 years ago

For the tagging logic you can use a custom command that runs a docker container with an xml parser installed . As it stands now it will pass a package md5 as the build arg and bomb out on download for a live build.

thelamer commented 5 years ago

Like this

https://github.com/linuxserver/docker-oscam/blob/master/jenkins-vars.yml#L6

CHBMB commented 5 years ago

@thelamer Thanks, I've implemented that now, also updated 50-config and added a default .htaccess file as I realised pretty URLs and subfolder reverse proxy support is probably a necessary requirement.

root@server:~# docker run --rm alpine:3.9 sh -c 'apk add xmlstarlet > /dev/null 2>&1 && wget https://download.dokuwiki.org/rss -O - 2>/dev/null | xmlstarlet sel -T -t -v '/rss/channel/item[1]/link' | cut -d'-' -f2-4 | cut -d'.' -f1'
Unable to find image 'alpine:3.9' locally
3.9: Pulling from library/alpine
e7c96db7181b: Already exists 
Digest: sha256:769fddc7cc2f0a1c35abb2f91432e8beecf83916c421420e6a6da9f8975464b6
Status: Downloaded newer image for alpine:3.9
2018-04-22b
thelamer commented 5 years ago

Alpine does not wget by default , you should be able to run the docker command locally and witness the exact output you get

CHBMB commented 5 years ago

@thelamer Just updated my original post as you were typing to show the output. Think that's working

thelamer commented 5 years ago

There is a busybox version of wget in the base container, learn something new everyday

LinuxServer-CI commented 5 years ago

I am a bot, here are the test results for this PR: https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/dokuwiki/2018-04-22b-pkg-none-pr-3/index.html https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/dokuwiki/2018-04-22b-pkg-none-pr-3/shellcheck-result.xml

LinuxServer-CI commented 5 years ago

I am a bot, here are the test results for this PR: https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/dokuwiki/2018-04-22b-pkg-none-pr-3/index.html https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/dokuwiki/2018-04-22b-pkg-none-pr-3/shellcheck-result.xml

LinuxServer-CI commented 5 years ago

I am a bot, here are the test results for this PR: https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/dokuwiki/2018-04-22b-pkg-none-pr-3/index.html https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/dokuwiki/2018-04-22b-pkg-none-pr-3/shellcheck-result.xml

CHBMB commented 5 years ago

I need to remove the $APP_URL setting.

LinuxServer-CI commented 5 years ago

I am a bot, here are the test results for this PR: https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/dokuwiki/2018-04-22b-pkg-none-pr-3/index.html https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/dokuwiki/2018-04-22b-pkg-none-pr-3/shellcheck-result.xml

LinuxServer-CI commented 5 years ago

I am a bot, here are the test results for this PR: https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/dokuwiki/2018-04-22b-pkg-none-pr-3/index.html https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/dokuwiki/2018-04-22b-pkg-none-pr-3/shellcheck-result.xml