linuxserver / docker-dokuwiki

GNU General Public License v3.0
110 stars 24 forks source link

Custom Smiley and Interwiki icons do not work because folders not persisted #40

Closed MachX428 closed 1 year ago

MachX428 commented 2 years ago

linuxserver.io

Following the official DokuWiki documentation for working with custom smileys (https://www.dokuwiki.org/smileys) and interwiki icons (https://www.dokuwiki.org/interwiki) does not result in the custom icons being displayed. This is because the folders the user is supposed to put the icons into are not properly persisted outside of the docker container.


Expected Behavior

The official DokuWiki documentation for working with smiley's (https://www.dokuwiki.org/smileys) and interwiki icons (https://www.dokuwiki.org/interwiki) describes putting them in the following folders:

It is expected that putting icons in these locations will allow them to be accessed and displayed if one follows the rest of the official documentation and creates the appropriate .conf files and references.

Current Behavior

The current container does not persist these locations outside of the container, so adding icons to these locations as described in the official documentation does not work and the custom icons are not displayed.

Steps to Reproduce

===== Smiley =====

:SMILEYTEST:

  * Verify that the text ":SMILEYTEST:" and a generic icon appears
    * **If it was working correctly, the smiley image you saved would appear instead**
  * Create an interwiki folder as described in the official documentation: https://www.dokuwiki.org/interwiki
    * `config/dokuwiki/lib/images/interwiki`
  * Use your favorite paint program to create a 16x16 pixel red square and save it as ubuntu.png
    * Move it to the interwiki folder you created
  * Create a `config/dokuwiki/conf/interwiki.local.conf` file 

Testing Interwiki's

ubuntu https://wiki.ubuntu.com/{NAME}

  * Edit your DokuWiki test page and add the text "[[ubuntu>teams|Ubuntu Teams]]"  

====== Test ======

===== Smiley =====

:SMILEYTEST:

===== Interwiki =====

[[ubuntu>teams|Ubuntu Teams]]

  * Verify that a generic circle icon appears next to the interwiki link you created
    * **If it was working correctly, the red square icon you created would appear instead**

## Environment
**OS:** ubuntu-20.04.2-live-server
**CPU architecture:** x86_64
**How docker service was installed:**
<!--- ie. from the official docker repo, from the distro repo, nas OS provided, etc. -->
<!--- Providing context helps us come up with a solution that is most useful in the real world -->

## Command used to create docker container (run/create/compose/screenshot)
<!--- Provide your docker create/run command or compose yaml snippet, or a screenshot of settings if using a gui to create the container -->

`sudo docker-compose up -d`

version: "2.1" services: dokuwiki: image: ghcr.io/linuxserver/dokuwiki container_name: dokuwiki-test environment:

github-actions[bot] commented 2 years ago

Thanks for opening your first issue here! Be sure to follow the bug or feature issue templates!

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

MachX428 commented 2 years ago

I submitted PR #41 to fix this issue. Is there anything else I need to do in order to get the PR approved and this issue closed? This is my first issue submission/PR here, so if I have forgotten something please just let me know.

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

MachX428 commented 2 years ago

Commenting to indicate I still have interest. There is a PR submitted that solves this. What can I do to get it approved? Or if there is a reason that someone does not want to approve it, could you please just let me know what that is so I might have a chance to correct it or discuss? Thank you.

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.