search

linuxserver / docker-dokuwiki

GNU General Public License v3.0
110 stars 24 forks source link

Error with some plugins and PHP8 #50

Closed trapexit closed 1 year ago

trapexit commented 1 year ago

Expected Behavior

Plugin should work as in normal install.

Current Behavior

A number of plugins appear incompatible with PHP8. ckgedit and cleanuphistory for instance.

Steps to Reproduce

  1. Run container as shown in instructions
  2. Install "ckgedit" by Myron Turner
  3. Edit page
  4. Select "Link"
  5. Change "Link Type" to "internal link" or "internal media" and then click "Browse Server"
  6. Error occurs

Environment

OS: Armbian CPU architecture: arm64 How docker service was installed: distro repo

It's a pretty standard setup.

Command used to create docker container (run/create/compose/screenshot)

Identical to docker-compose setup from docs.

Docker logs

nginx's error.log

2022/10/03 18:33:29 [error] 224#224: *39 FastCGI sent in stderr: "PHP message: PHP Fatal error:  Array and string offset access syntax with curly braces is no longer supported in /config/dokuwiki/lib/plugins/ckgedit/fckeditor/editor/filemanager/connectors/php/check_acl.php on line 175" while reading response header from upstream, client: 192.168.1.133, server: _, request: "GET /lib/plugins/ckgedit/fckeditor/editor/filemanager/connectors/php/connector.php?Command=GetFoldersAndFiles&Type=File&CurrentFolder=/&uuid=1664836409342 HTTP/1.1", upstream: "fastcgi://127.0.0.1:9000", host: "192.168.1.203", referrer: "http://192.168.1.203/lib/plugins/ckgedit/fckeditor/editor/filemanager/browser/default/browser.html?Type=File&Connector=/lib/plugins/ckgedit/fckeditor/editor/filemanager/connectors/php/connector.php&CKEditor=wiki__text&CKEditorFuncNum=1&langCode=en"
2022/10/03 18:33:29 [error] 224#224: *42 FastCGI sent in stderr: "PHP message: PHP Fatal error:  Array and string offset access syntax with curly braces is no longer supported in /config/dokuwiki/lib/plugins/ckgedit/fckeditor/editor/filemanager/connectors/php/check_acl.php on line 175" while reading response header from upstream, client: 192.168.1.133, server: _, request: "GET /lib/plugins/ckgedit/fckeditor/editor/filemanager/connectors/php/connector.php?Command=GetFolder
sAndFiles&Type=File&CurrentFolder=/&uuid=1664836409341 HTTP/1.1", upstream: "fastcgi://127.0.0.1:9000", host: "192.168.1.203", referrer: "http://192.168.1.203/lib/plugins/ckgedit/fckeditor/editor/filemanager/browser/default/browser.html?Type=File&Connector=/lib/plugins/ckgedit/fckeditor/editor/filemanager/connectors/php/connector.php&CKEditor=wiki__text&CKEditorFuncNum=1&langCode=en"
2022/10/03 18:33:29 [error] 224#224: *39 FastCGI sent in stderr: "PHP message: PHP Fatal error:  Array and string offset access syntax with curly braces is no longer supported in /config/dokuwiki/lib/plugins/ckgedit/fckeditor/editor/filemanager/connectors/php/check_acl.php on line 175" while reading response header from upstream, client: 192.168.1.133, server: _, request: "GET /lib/plugins/ckgedit/fckeditor/editor/filemanager/connectors/php/connector.php?Command=GetFoldersAndFiles&Type=File&CurrentFolder=/&uuid=1664836409342 HTTP/1.1", upstream: "fastcgi://127.0.0.1:9000", host: "192.168.1.203", referrer: "http://192.168.1.203/lib/plugins/ckgedit/fckeditor/editor/filemanager/browser/default/browser.html?Type=File&Connector=/lib/plugins/ckgedit/fckeditor/editor/filemanager/connectors/php/connector.php&CKEditor=wiki__text&CKEditorFuncNum=1&langCode=en"
2022/10/03 18:33:29 [error] 224#224: *39 FastCGI sent in stderr: "PHP message: PHP Fatal error:  Array and string offset access syntax with curly braces is no longer supported in /config/dokuwiki/lib/plugins/ckgedit/fckeditor/editor/filemanager/connectors/php/check_acl.php on line 175" while reading response header from upstream, client: 192.168.1.133, server: _, request: "GET /lib/plugins/ckgedit/fckeditor/editor/filemanager/connectors/php/connector.php?Command=GetFolder
sAndFiles&Type=File&CurrentFolder=/&uuid=1664836409432 HTTP/1.1", upstream: "fastcgi://127.0.0.1:9000", host: "192.168.1.203", referrer: "http://192.168.1.203/lib/plugins/ckgedit/fckeditor/editor/filemanager/browser/default/browser.html?Type=File&Connector=/lib/plugins/ckgedit/fckeditor/editor/filemanager/connectors/php/connector.php&CKEditor=wiki__text&CKEditorFuncNum=1&langCode=en"
2022/10/03 18:33:29 [error] 224#224: *42 FastCGI sent in stderr: "PHP message: PHP Fatal error:  Array and string offset access syntax with curly braces is no longer supported in /config/dokuwiki/lib/plugins/ckgedit/fckeditor/editor/filemanager/connectors/php/check_acl.php on line 175" while reading response header from upstream, client: 192.168.1.133, server: _, request: "GET /lib/plugins/ckgedit/fckeditor/editor/filemanager/connectors/php/connector.php?Command=GetFoldersAndFiles&Type=File&CurrentFolder=/&uuid=1664836409439 HTTP/1.1", upstream: "fastcgi://127.0.0.1:9000", host: "192.168.1.203", referrer: "http://192.168.1.203/lib/plugins/ckgedit/fckeditor/editor/filemanager/browser/default/browser.html?Type=File&Connector=/lib/plugins/ckgedit/fckeditor/editor/filemanager/connectors/php/connector.php&CKEditor=wiki__text&CKEditorFuncNum=1&langCode=en"
2022/10/03 18:33:29 [error] 224#224: *39 FastCGI sent in stderr: "PHP message: PHP Fatal error:  Array and string offset access syntax with curly braces is no longer supported in /config/dokuwiki/lib/plugins/ckgedit/fckeditor/editor/filemanager/connectors/php/check_acl.php on line 175" while reading response header from upstream, client: 192.168.1.133, server: _, request: "GET /lib/plugins/ckgedit/fckeditor/editor/filemanager/connectors/php/connector.php?Command=GetFolder
sAndFiles&Type=File&CurrentFolder=/&uuid=1664836409432 HTTP/1.1", upstream: "fastcgi://127.0.0.1:9000", host: "192.168.1.203", referrer: "http://192.168.1.203/lib/plugins/ckgedit/fckeditor/editor/filemanager/browser/default/browser.html?Type=File&Connector=/lib/plugins/ckgedit/fckeditor/editor/filemanager/connectors/php/connector.php&CKEditor=wiki__text&CKEditorFuncNum=1&langCode=en"
2022/10/03 18:33:29 [error] 224#224: *42 FastCGI sent in stderr: "PHP message: PHP Fatal error:  Array and string offset access syntax with curly braces is no longer supported in /config/dokuwiki/lib/plugins/ckgedit/fckeditor/editor/filemanager/connectors/php/check_acl.php on line 175" while reading response header from upstream, client: 192.168.1.133, server: _, request: "GET /lib/plugins/ckgedit/fckeditor/editor/filemanager/connectors/php/connector.php?Command=GetFoldersAndFiles&Type=File&CurrentFolder=/&uuid=1664836409439 HTTP/1.1", upstream: "fastcgi://127.0.0.1:9000", host: "192.168.1.203", referrer: "http://192.168.1.203/lib/plugins/ckgedit/fckeditor/editor/filemanager/browser/default/browser.html?Type=File&Connector=/lib/plugins/ckgedit/fckeditor/editor/filemanager/connectors/php/connector.php&CKEditor=wiki__text&CKEditorFuncNum=1&langCode=en"
trapexit commented 1 year ago

It appears to be a php8 compatibility issue. I've seen a few issues with plugins and php8. Any chance of a php7 based version? I quickly changed the base image and this one to 7 and it looks to work with ckgedit. Will do more testing to confirm.

turnermm commented 1 year ago

That is a common PHP 8 compatibility issue, not easy to catch them all in such a large project. I'll let you know when it's corrected in case you want to revert back to PHP 8.

turnermm commented 1 year ago

fixed

trapexit commented 1 year ago

Thanks. I'll take a look. That said I had other failures with this php8 based image so I'll probably keep my php7 version for now but will create a mirror to test 8 further.