linuxserver / docker-doublecommander

GNU General Public License v3.0
33 stars 2 forks source link

[BUG] Settings lost after using a new image #19

Closed vdb86 closed 1 year ago

vdb86 commented 1 year ago

Is there an existing issue for this?

Current Behavior

I had several things set up with DC, and those settings were saved, so each time the container was started the setting were loaded. After I pulled an updated image and run the container, everything went back to default settings. I thought the settings were saved in the /config, so after using the updated image I would have expected them to be loaded normally, but I can't find the settings file, which makes me think it is saved within the container?

Expected Behavior

After getting an updated image and starting the new container, the settings are preserved and loaded.

Steps To Reproduce

  1. Change some settings in DC, make sure you exit so that it saves your settings
  2. Start it up and verify that they are loaded
  3. Now update the image and start the container again
  4. You'll see that your settings are lost

Environment

- OS: Libreelec
- How docker service was installed: Through Libreelec

CPU architecture

arm64

Docker creation

I'm using portainer to run the containers.
---
version: "2.1"
services:
  doublecommander:
    image: lscr.io/linuxserver/doublecommander:arm64v8-latest
    container_name: doublecommander
    environment:
      - PUID=0
      - PGID=0
      - TZ=Europe/Belgrade
    volumes:
      - /storage/.kodi/userdata/addon_data/service.system.docker/docker/volumes/doublecommander:/config
      - /storage/downloads/complete:/data/complete
      - Server1:/data/server1
      - Server2:/data/server2
    network_mode: "host"
    ports:
      - 3000:3000
      - 3001:3001
    restart: unless-stopped

Container logs

I can't seem to get this.
github-actions[bot] commented 1 year ago

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

aptalca commented 1 year ago

The folder you're mapping for the config folder is meant to be managed by the docker service only. You shouldn't be bind mapping or even directly using those.

vdb86 commented 1 year ago

Hello and thank you for your reply! I've used the docker compose in portainer, that was provided by linuxserver. I added my info as needed in that docker compose. Apologies for my lack of knowledge, should have I done something in a different way?

Where could I find the double commander settings files and how do I ensure they are not lost after an updated container is started?

aptalca commented 1 year ago

We don't provide or suggest this anywhere /storage/.kodi/userdata/addon_data/service.system.docker/docker/volumes/doublecommander:/config

Use a different folder like /storage/doublecommander

vdb86 commented 1 year ago

Docker compose says: path/to/config:/config

So I've put my path to config as I use with other containers as well.

I'll try with your suggestion, should that ensure the setting is kept after an updated container runs?

vdb86 commented 1 year ago

I've changed the path to storage/docker/doublecommander But I'm still not seeing the settings files anywhere. Do you know where they are saved?

vdb86 commented 1 year ago

After a very detailed review and a lot of help on Discord multiple things were caught:

I'm 100% sure that if you don't use Portainer, but actually create your containers directly through docker everything will work just fine.

Big thanks for linuxserver for awesome images and for the discord people who showed a lot of patience and good will throughout this investigation.