linuxserver / docker-emby

GNU General Public License v3.0
119 stars 40 forks source link

add vaapi drivers for AMD hardware #25

Closed bajo closed 4 years ago

bajo commented 4 years ago

linuxserver.io


We welcome all PR’s though this doesn’t guarantee it will be accepted.

Description:

Install the Mesa VAAPI drivers to be able to use the device. Updated the ENV variable so that the ffmpeg, ffdetect binaries shipped with emby can use the drivers.

Benefits of this PR and context:

Started discussion at https://github.com/linuxserver/docker-baseimage-ubuntu/issues/44 and it was pointed out that it should be fixed in this specific repo instead. Benefit is that AMD users can use HW accelerated video encoding and decoding out of the box iff they have a Emby Premiere subscription.

How Has This Been Tested?

Locally build the docker image and used it as with docker-compose as described in the original Readme

LinuxServer-CI commented 4 years ago

I am a bot, here are the test results for this PR: https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/emby/4.4.3.0-pkg-3228eaa0-pr-25/index.html https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/emby/4.4.3.0-pkg-3228eaa0-pr-25/shellcheck-result.xml

aptalca commented 4 years ago

@bajo did you test this? Emby is not detecting any hw decoder or encoder for me.

EDIT: Scratch that, I used the wrong image. This seems to work. Thanks a lot

LinuxServer-CI commented 4 years ago

I am a bot, here are the test results for this PR: https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/emby/4.4.3.0-pkg-3228eaa0-pr-25/index.html https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/emby/4.4.3.0-pkg-3228eaa0-pr-25/shellcheck-result.xml

bajo commented 4 years ago

@aptalca thank you for the cleanup.