search

linuxserver / docker-emby

GNU General Public License v3.0
119 stars 40 forks source link

Emby - Addition of ComSkip within container #95

Closed pbathuk closed 8 months ago

pbathuk commented 8 months ago

linuxserver.io

Description:

fixes #94 by adding Comskip build into the DockerFile. This is my first PR on this, and did try to speak on Discord, but even though I ticked the Welcome Message and confirmed acceptance, I am locked out of the channels.

Benefits of this PR and context:

Having Comskip as part of the container removes a requirement for users, building comskip is not hard, but does mean that rather than being able to install via this docker, it must be installed on the bare metal.. which is something personally I prefer not to do.

How Has This Been Tested?

I did try to run the dockerfile (as is), on my own PC, but got the following message:

=> => extracting sha256:9d9c93f4b00be908ab694a4df732570bced3b8a96b7515d70ff93402179ad232               0.1s
 => ERROR [internal] load metadata for docker.io/library/buildstage:latest                              0.7s
 => CANCELED [internal] load metadata for ghcr.io/linuxserver/baseimage-ubuntu:jammy                    0.7s
 => [auth] library/buildstage:pull token for registry-1.docker.io                                       0.0s

I believe this is because I don't have auth (quite rightly) to the information. If I have missed something please let me know, and I am happy to complete as much testing is required.

Source / References:

I have referenced https://github.com/linuxserver/docker-tvheadend/tree/master and used this as a guide

pbathuk commented 8 months ago

It appears the jenkins build has failed for the same reason. I don't believe I have pulled a new image. So Have obviously caused some type of error.

If someone could give me guidance on this, that would really help

aptalca commented 8 months ago

Thanks for the PR

There are several issues with the Dockerfile, but in any case, this is best added as a docker mod: https://mods.linuxserver.io/?mod=create

pbathuk commented 8 months ago

Thanks, really sorry I missed that & the docker mod thing.. I thought I had read everything.

I will look at the dockermod info now.