search

linuxserver / docker-emulatorjs

Web based retro emulation frontend with rom scanning and automated art ingestion.
GNU General Public License v3.0
509 stars 51 forks source link

Rebase to 3.17, migrate to s6v3 #44

Closed thespad closed 1 year ago

thespad commented 1 year ago

linuxserver.io

Description:

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

LinuxServer-CI commented 1 year ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/emulatorjs/1.7.2-pkg-dcc7d7b3-pr-44/index.html https://ci-tests.linuxserver.io/lspipepr/emulatorjs/1.7.2-pkg-dcc7d7b3-pr-44/shellcheck-result.xml

thelamer commented 1 year ago

This is good stuff, this one has actually been sitting because of the ipfs upgrade in 3.17.

To facilitate upgrades it needs logic to migrate the local data https://github.com/linuxserver/docker-ipfs/blob/master/root/etc/cont-init.d/40-migrate Which also needs compiled migration bins: https://github.com/linuxserver/docker-ipfs/blob/master/Dockerfile#L1

And on top of that the main seed endpoint might need to be updated to get everything working. I have a Todo for this after I finish webtop.

thespad commented 1 year ago

Added the migrations and tested a little. Had to pull from head because the latest release in the migrations repo doesn't include v12 which is what's required for the version in the 3.17 repos.

LinuxServer-CI commented 1 year ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/emulatorjs/1.7.2-pkg-dcc7d7b3-pr-44/index.html https://ci-tests.linuxserver.io/lspipepr/emulatorjs/1.7.2-pkg-dcc7d7b3-pr-44/shellcheck-result.xml

github-actions[bot] commented 1 year ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 1 year ago

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

thespad commented 1 year ago

Superseded by https://github.com/linuxserver/docker-emulatorjs/pull/47

github-actions[bot] commented 1 year ago

This pull request is locked due to inactivity