linuxserver / docker-emulatorjs

Web based retro emulation frontend with rom scanning and automated art ingestion.
GNU General Public License v3.0
509 stars 51 forks source link

Add URL parameter before #game #64

Closed dosboxonline closed 4 months ago

dosboxonline commented 7 months ago

Is this a new feature request?

Wanted change

Add URL parameter to separate game headers and navigation menu headers. Example - https://192.168.1.1/?play=online#game

Reason for change

"Cross-Origin-Embedder-Policy: require-corp" and "Cross-Origin-Opener-Policy: same-origin" headers only game start.

Proposed code change

I try this in index.js file - window.location.href = '?play=online' + '#game'; but it loses data to launch the game. Can you tell me what needs to be changed in the Index.js file? Thanks.

github-actions[bot] commented 7 months ago

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

thelamer commented 7 months ago

This would break entering the game in fullscreen mode which is one of my main use cases. I am still trying to figure out a non obtrusive way to keep the whole thing full screen when navigating to submenus as Istill want to provide the user with permalinks that can be used for specific submenus and games.

What occurs in the frontend is the scripts to launch the game are injected into the page:

https://github.com/linuxserver/emulatorjs/blob/master/frontend/js/index.js#L142 https://github.com/linuxserver/emulatorjs/blob/master/frontend/js/index.js#L206-L208

But what you are looking for is the location change here I believe? https://github.com/linuxserver/emulatorjs/blob/master/frontend/js/index.js#L136

dosboxonline commented 7 months ago

Yes. This makes it possible to embed content from third-party resources without losing the ability to launch libretro-yabause_threaded and libretro-melonds_threaded. In CloudFlare it is possible to launch a website through a "Tunnel" and then there is no need to install an SSL on the server. And than create new HTTP Response Header Modification Rule.

dosboxonline commented 7 months ago

Sorry for the off-topic post. I just took the opportunity to share. I remember someone asking about the missing logos and videos. On this sites - https://gamesdb.launchbox-app.com/#s , https://db.hfsplay.fr/games/ and this https://emumovies.com/ Logos and video snaps that the EmulatorJs download + for all other existing games.

LinuxServer-CI commented 6 months ago

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 3 months ago

This issue is locked due to inactivity