search

linuxserver / docker-emulatorjs

Web based retro emulation frontend with rom scanning and automated art ingestion.
GNU General Public License v3.0
509 stars 51 forks source link

Skip IPFS config if DISABLE_IPFS env var is set #67

Closed hulkhaugen closed 7 months ago

hulkhaugen commented 7 months ago

linuxserver.io

Description:

Using the DISABLE_IPFS environment variable to skip the IPFS config in the init-emulatorjs-config script if the variable is set. Also added a few double-quotes on some variables that were missing.

Benefits of this PR and context:

It reduces startup time and resource use for users that have disabled IPFS.

How Has This Been Tested?

I have made a local build and tested, works fine for me. In my test setup, i also erase the remains of the /data/.ipfs, but I have not done it in this pull request as it might not align with others views.

Source / References:

N/A

LinuxServer-CI commented 7 months ago
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/emulatorjs/1.8.5-pkg-5ad17c44-dev-81f1717a95b4c4220f07dbde73926d0b088c0a0e-pr-67/index.html https://ci-tests.linuxserver.io/lspipepr/emulatorjs/1.8.5-pkg-5ad17c44-dev-81f1717a95b4c4220f07dbde73926d0b088c0a0e-pr-67/shellcheck-result.xml Tag Passed
amd64-1.8.5-pkg-5ad17c44-dev-81f1717a95b4c4220f07dbde73926d0b088c0a0e-pr-67 ✅
arm64v8-1.8.5-pkg-5ad17c44-dev-81f1717a95b4c4220f07dbde73926d0b088c0a0e-pr-67 ✅