github-actions[bot]
commented
6 months ago Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.
Closed mpclepto closed 6 months ago
github-actions[bot]
commented
6 months ago Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.
thelamer
commented
6 months ago binmerge might need some kind of file locking that unraid's fuse lacks, I cannot replicate this locally on a normal Linux filesystem. The first thing to try is doing this with /data/ mounted to a cache drive or directly to a disk to see if it works as a test.
thelamer
commented
6 months ago You can also try execing into the container and testing a head script.
docker exec -it emulatorjs bash
cd /emulatorjs
rm has_files.sh
wget https://raw.githubusercontent.com/linuxserver/emulatorjs/master/has_files.sh
chmod +x has_files.shThe scan won't error out on multi track files but you will need to manually identify them in the management screen with this change. Without the sha1 from the actual track there is no reference data I can use to automatically link the file.
If this change works please confirm and I can get it into the next release.
mpclepto
commented
6 months ago You can also try execing into the container and testing a head script.
docker exec -it emulatorjs bash cd /emulatorjs rm has_files.sh wget https://raw.githubusercontent.com/linuxserver/emulatorjs/master/has_files.sh chmod +x has_files.shThe scan won't error out on multi track files but you will need to manually identify them in the management screen with this change. Without the sha1 from the actual track there is no reference data I can use to automatically link the file.
If this change works please confirm and I can get it into the next release.
I just tested this script while I had a free moment and it worked exactly as you described it would.
Would you like me to try the /data mount test as well?
thelamer
commented
6 months ago Naw, I don't run unraid but I would assume this is the issue, binmerge does byte reads and pipes out files which likely does not work on fuse based storage.
I'll cut a bugfix release it will take a bit to build.
mpclepto
commented
6 months ago Awesome, thank you!
Is there an existing issue for this?
Current Behavior
Using a psx .chd file (tekken 3), I am trying to scan it into the Rom Management tab, but I am seeing the following permission error. I gave full 777 to the following folders to no avail:
/data/hashes/psx/roms/tmp/split /data/hashes/psx/roms/tmp/
Scan exited with code: 1 PermissionError: [Errno 13] Permission denied: 'FILE (Track 1).bin' ^^^^^^^^^^^^^^^^^^^^ with open(out_name, 'wb') as outfile: File "/usr/local/bin/binmerge", line 254, in split_files ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ if split_files(os.path.join(outdir, args.basename), cue_map[0]): File "/usr/local/bin/binmerge", line 347, in main ^^^^^^ if not main(): File "/usr/local/bin/binmerge", line 367, in Traceback (most recent call last): [INFO] Output directory: /data/hashes/psx/roms/tmp/split [INFO] Opening cue: /data/hashes/psx/roms/tmp/FILE.cue [INFO] Splitting files... Tekken 3 (USA).chd is multi track need to split Extraction complete Extracting, 91.9% complete...
Expected Behavior
No response
Steps To Reproduce
Environment
CPU architecture
x86-64
Docker creation
Container logs