linuxserver / docker-freshrss

GNU General Public License v3.0
157 stars 24 forks source link

BASE_URL env variable #44

Closed pr3d1 closed 1 year ago

pr3d1 commented 1 year ago

linuxserver.io

Defining a BASE_URL env variable for the container.

Desired Behavior

I need to modify the base_url parameter inside the config.php file. I think it would be nice if the container could accept a BASE_URL env variable, like in this page.

Current Behavior

The BASE_URL env variable does not affect for the config.php file.

Alternatives Considered

I defined a K8S configmap and used it for this purpose, but i think it would be nice, if we can use an env variable for this purpose.

github-actions[bot] commented 1 year ago

Thanks for opening your first issue here! Be sure to follow the bug or feature issue templates!

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

nemchik commented 1 year ago

I'm not entirely sure how the app inside the container is reading the variable from the environment. I searched BASE_URL in the upstream repo and it mostly just looks like it reads from the config file, not the environment. If you have any more information about how this is expected to be handled I would be open to making adjustments here.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

drizuid commented 1 year ago

No further info provided by OP, closing.