search

linuxserver / docker-freshrss

GNU General Public License v3.0
157 stars 24 forks source link

[BUG] Latest does not put all necessary data in /config #45

Closed traeblain closed 1 year ago

traeblain commented 1 year ago

Is there an existing issue for this?

Current Behavior

config directory only has

Expected Behavior

Previous versions had multiple directories like:

Not sure if all of these were used, but if I want a custom theme (previously in the "p" directory), I cannot see it to add one.

Steps To Reproduce

fresh docker install

Environment

- OS: Ubuntu 20.04
- How docker service was installed: apt

CPU architecture

x86-64

Docker creation

freshrss:
    image: lscr.io/linuxserver/freshrss:latest
    container_name: freshrss
    environment:
      - PUID=${PUID}
      - PGID=${PGID}
      - TZ=${TZ}
    volumes: 
      - /home/user/data/freshrss:/config
    restart: unless-stopped
    labels:
      - "traefik.enable=true"
      - "traefik.http.routers.freshrss.rule=Host(`example.com`)"
      - "traefik.http.routers.freshrss.service=freshrss"
      - "traefik.http.services.freshrss.loadbalancer.server.port=80"
      - "traefik.http.routers.freshrss.entrypoints=websecure"
      - "traefik.http.routers.freshrss.tls.certresolver=le"
      - "traefik.docker.network=proxy"
    networks:
      - proxy
      - default

### Container logs

```bash
-------------------------------------
          _         ()
         | |  ___   _    __
         | | / __| | |  /  \
         | | \__ \ | | | () |
         |_| |___/ |_|  \__/

Brought to you by linuxserver.io
-------------------------------------

To support LSIO projects visit:
https://www.linuxserver.io/donate/
-------------------------------------
GID/UID
-------------------------------------

User uid:    1000
User gid:    1000
-------------------------------------

cont-init: info: /etc/cont-init.d/10-adduser exited 0
cont-init: info: running /etc/cont-init.d/11-folders
cont-init: info: /etc/cont-init.d/11-folders exited 0
cont-init: info: running /etc/cont-init.d/12-samples
cont-init: info: /etc/cont-init.d/12-samples exited 0
cont-init: info: running /etc/cont-init.d/13-nginx
Setting resolver to  127.0.0.11
Setting worker_processes to 4
cont-init: info: /etc/cont-init.d/13-nginx exited 0
cont-init: info: running /etc/cont-init.d/14-php
cont-init: info: /etc/cont-init.d/14-php exited 0
cont-init: info: running /etc/cont-init.d/15-keygen
generating self-signed keys in /config/keys, you can replace these with your own keys if required
Generating a RSA private key
..................+++++
......................+++++
writing new private key to '/config/keys/cert.key'
-----
cont-init: info: /etc/cont-init.d/15-keygen exited 0
cont-init: info: running /etc/cont-init.d/20-permissions
cont-init: info: /etc/cont-init.d/20-permissions exited 0
cont-init: info: running /etc/cont-init.d/40-install
cont-init: info: /etc/cont-init.d/40-install exited 0
cont-init: info: running /etc/cont-init.d/85-version-checks
cont-init: info: /etc/cont-init.d/85-version-checks exited 0
cont-init: info: running /etc/cont-init.d/99-custom-files
[custom-init] No custom files found, skipping...
cont-init: info: /etc/cont-init.d/99-custom-files exited 0
s6-rc: info: service legacy-cont-init successfully started
s6-rc: info: service init-mods: starting
s6-rc: info: service init-mods successfully started
s6-rc: info: service init-mods-package-install: starting
s6-rc: info: service init-mods-package-install successfully started
s6-rc: info: service init-mods-end: starting
s6-rc: info: service init-mods-end successfully started
s6-rc: info: service init-services: starting
s6-rc: info: service init-services successfully started
s6-rc: info: service legacy-services: starting
services-up: info: copying legacy longrun cron (no readiness notification)
services-up: info: copying legacy longrun nginx (no readiness notification)
services-up: info: copying legacy longrun php-fpm (no readiness notification)
s6-rc: info: service legacy-services successfully started
s6-rc: info: service 99-ci-service-check: starting
[ls.io-init] done.
s6-rc: info: service 99-ci-service-check successfully started
github-actions[bot] commented 1 year ago

Thanks for opening your first issue here! Be sure to follow the bug or feature issue templates!

nemchik commented 1 year ago

The image was adjusted in https://github.com/linuxserver/docker-freshrss/pull/33 (merged in March 2020) to not install the app in the user /config and instead keep the app itself inside the container. Without this approach, if a user updates the container image they would not actually be updating the app itself (just the underlying dependencies) which can actually cause the application to break in some cases.

The image was further adjusted in https://github.com/linuxserver/docker-freshrss/pull/40 (merged in October 2022 and accompanied by an announcement on our info site https://info.linuxserver.io/issues/2022-08-20-nginx-base/ and discord announcement channel) to adjust the location inside the container where the app is installed and align the internal file structure and nginx configs to a standard layout we are now using across all of our nginx based images.

40 should not be what affected your ability to access the entirety of the application via the /config volume (I expect it would have been #33 ).

We currently do not have it documented, but it is possible to mount anything you'd like the app to see beneath /app/www. For example; you mentioned themes, and they are located at /app/www/p/themes. I would not recommend directly mounting /app/www/p/themes as a volume, but maybe mounting a subfolder such as /app/www/p/themes/myCustomTheme with just your theme (instead of the whole themes folder). This way the base themes will continue to be provided by and updated with the image. Another option would be to add a custom init script ( https://www.linuxserver.io/blog/2019-09-14-customizing-our-containers ) to copy your theme from somewhere like /config/www/freshrss/p/themes/myCustomTheme to /app/www/p/themes/myCustomTheme when the container starts, or symlink it instead of copying it.

I'm open to adjusting the image to make it more usable to accommodate needs like custom themes, but we'll need to discuss how to accomplish that without breaking existing installs and while keeping the themes included in the image updated properly.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 1 year ago

This issue is locked due to inactivity