linuxserver / docker-freshrss

GNU General Public License v3.0
157 stars 24 forks source link

Increase php memory_limit to 256M #56

Closed th0mcat closed 1 year ago

th0mcat commented 1 year ago

linuxserver.io



Description:

I've been running into issues on a couple of Android apps (Read You, FreshRSS) where syncing is very slow or doesn't work at all. Changing the memory_limit in /etc/php81/php.ini or ./config/php/php-local.ini fixed the issue.

Benefits of this PR and context:

Increased performance in mobile apps

How Has This Been Tested?

· Downloaded both Read You and FreshRSS Android apps · Logged in and forced a sync · App error for FreshRSS is gone and articles are pulled. Read You syncs much faster.

Source / References:

https://gitlab.com/christophehenry/freshrss-android/-/issues/124#note_1382399590

LinuxServer-CI commented 1 year ago
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/freshrss/1.21.0-pkg-0d32494a-pr-56/index.html https://ci-tests.linuxserver.io/lspipepr/freshrss/1.21.0-pkg-0d32494a-pr-56/shellcheck-result.xml Tag Passed
amd64-1.21.0-pkg-0d32494a-pr-56
arm32v7-1.21.0-pkg-0d32494a-pr-56
arm64v8-1.21.0-pkg-0d32494a-pr-56
nemchik commented 1 year ago

That file does not exist at build time. It gets created at run time via https://github.com/linuxserver/docker-baseimage-alpine-nginx/blob/master/root/etc/s6-overlay/s6-rc.d/init-php/run You would need to make an adjustment like that here https://github.com/linuxserver/docker-freshrss/blob/master/root/etc/s6-overlay/s6-rc.d/init-freshrss-config/run but this type of change is subjective and that value may not be right for every setup.

Further, the file does not have anything to replace, so you would have to add it if it does not exist, but again, I don't feel comfortable with setting this default value unless there is specific documentation from freshrss that it is the right value to use.

th0mcat commented 1 year ago

Fair enough. Thanks!