search

linuxserver / docker-grocy

A container for grocy - the ERP application for your kitchen https://grocy.info
GNU General Public License v3.0
333 stars 44 forks source link

Docker tag 2.6.2 contains version 2.6.1 of the aplication #19

Closed lyz-code closed 3 years ago

lyz-code commented 4 years ago

Expected Behavior

Docker image with tag latest or v2.6.2-ls53 should contain version 2.6.2 of the application.

Current Behavior

When doing docker pull the image starts version 2.6.1, and the digest doesn't match the one in dockerhub.

[
    {
        "Id": "sha256:def8f513ce05fac44f0a075d113848f28fb22ad2f079015cd8274200b5cb8081",
        "RepoTags": [
            "linuxserver/grocy:latest"
        ],
        "RepoDigests": [
            "linuxserver/grocy@sha256:b0ff777d57b1dd0b7c0689637f7f480624fcd1bef1e20145b3254d6480c28b8f"
        ],
        "Parent": "",
        "Comment": "",
        "Created": "2020-04-03T17:39:12.990233467Z",
        "Container": "79314721638d0ff6a628447d19e7f4881103e37396ca77929e1e8028130c2020",
        "ContainerConfig": {
            "Hostname": "79314721638d",
            "Domainname": "",
            "User": "",
            "AttachStdin": false,
            "AttachStdout": false,
            "AttachStderr": false,
            "ExposedPorts": {
                "443/tcp": {},
                "6781/tcp": {},
                "80/tcp": {}
            },
            "Tty": false,
            "OpenStdin": false,
            "StdinOnce": false,
            "Env": [
                "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
                "PS1=$(whoami)@$(hostname):$(pwd)\\$ ",
                "HOME=/root",
                "TERM=xterm"
            ],
            "Cmd": [
                "/bin/sh",
                "-c",
                "#(nop) ",
                "VOLUME [/config]"
            ],
            "Image": "sha256:0e20851e249600f5a7fef9e99c9b2e65e5adf661e5ef2445efdd37bd7e59da5d",
            "Volumes": {
                "/config": {}
            },
            "WorkingDir": "",
            "Entrypoint": [
                "/init"
            ],
            "OnBuild": null,
            "Labels": {
                "build_version": "Linuxserver.io version:- v2.6.2-ls53 Build-date:- 2020-04-03T13:37:48-04:00",
                "maintainer": "alex-phillips, homerr"
            }
        },
        "DockerVersion": "19.03.8",
        "Author": "",
        "Config": {
            "Hostname": "",
            "Domainname": "",
            "User": "",
            "AttachStdin": false,
            "AttachStdout": false,
            "AttachStderr": false,
            "ExposedPorts": {
                "443/tcp": {},
                "6781/tcp": {},
                "80/tcp": {}
            },
            "Tty": false,
            "OpenStdin": false,
            "StdinOnce": false,
            "Env": [
                "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
                "PS1=$(whoami)@$(hostname):$(pwd)\\$ ",
                "HOME=/root",
                "TERM=xterm"
            ],
            "Cmd": null,
            "Image": "sha256:0e20851e249600f5a7fef9e99c9b2e65e5adf661e5ef2445efdd37bd7e59da5d",
            "Volumes": {
                "/config": {}
            },
            "WorkingDir": "",
            "Entrypoint": [
                "/init"
            ],
            "OnBuild": null,
            "Labels": {
                "build_version": "Linuxserver.io version:- v2.6.2-ls53 Build-date:- 2020-04-03T13:37:48-04:00",
                "maintainer": "alex-phillips, homerr"
            }
        },
        "Architecture": "amd64",
        "Os": "linux",
        "Size": 281830895,
        "VirtualSize": 281830895,
        "GraphDriver": {
            "Data": {
                "LowerDir": "/var/lib/docker/overlay2/5e52f0164c72825e0214fd9b2f97a8eee51135f942a1090c49c4b53a7bc6a49d/diff:/var/lib/docker/overlay2/5514e3859adb7f323f2fa6be3977bd9e8231123cd103e1a6bc427aaf845286ec/diff:/var/lib/docker/overlay2/8b64777ac85b6b14b63b5486562b54528628d6803be55c6acfad6ee0104a847c/diff:/var/lib/docker/overlay2/96f6a4b38c771c91fab567f433f545c9b0a1236fc37a69d39af6b2610858961f/diff:/var/lib/docker/overlay2/7bfc74b665b00ed55336ca420ae5d62325d494a5469880f097a688e9db9cbc0b/diff:/var/lib/docker/overlay2/5755d0f948a92ff31262f1a9f8299ba80d8961888d96807af94734e808a48a9c/diff",
                "MergedDir": "/var/lib/docker/overlay2/fe6efb06363d07a368dc4a7cfa5a216e654fcbd646b4f22f3ce6d298a3c515df/merged",
                "UpperDir": "/var/lib/docker/overlay2/fe6efb06363d07a368dc4a7cfa5a216e654fcbd646b4f22f3ce6d298a3c515df/diff",
                "WorkDir": "/var/lib/docker/overlay2/fe6efb06363d07a368dc4a7cfa5a216e654fcbd646b4f22f3ce6d298a3c515df/work"
            },
            "Name": "overlay2"
        },
        "RootFS": {
            "Type": "layers",
            "Layers": [
                "sha256:b0898de3b154dff78706c00c322894fe9c6af3bc3d141a849d364ef87c5edf5a",
                "sha256:92c48e398ada792c311e267cfee79ff486b269d25b43d6c5e153e4decc58e0b9",
                "sha256:539cb3f6ed23739964f4b63da6c3c1fc59a85c0648fc42ad696916b450b2151e",
                "sha256:4694852e1701a103c7ae8f9a5f46c9598ae2e62b3e210c70daf7867c797f1382",
                "sha256:211c49c7f47529b19690a39f3285df910c37facf7b852b9020cef1826ccac723",
                "sha256:d951a976037a0bc854dce80ac109cd30b4cb4e2ca6d6c3fcb19a26c423f2b2b1",
                "sha256:4d4ab0bf96944b94b08a4c3d5a0f5f998e84a4a9abc63befcc7c88a856e97430"
            ]
        },
        "Metadata": {
            "LastTagTime": "0001-01-01T00:00:00Z"
        }
    }
]

Steps to Reproduce

docker run -it --rm\
  --name=grocy \
  -e PUID=1000 \
  -e PGID=1000 \
  -e TZ=Europe/London \
  -p 127.0.0.1:9283:80 \
  linuxserver/grocy

Environment

OS: Debian Buster CPU architecture: x86_64
How docker service was installed: with the docker guide.

Command used to create docker container (run/create/compose/screenshot)

See above

aptalca commented 4 years ago

I'm gonna wager a guess that the app is displaying incorrect info.

Our builder passes the version as a docker arg and that arg is used to pull the grocy version from upstream repo: https://github.com/linuxserver/docker-grocy/blob/master/Dockerfile#L32

We are indeed pulling and installing the said version.

You can see here in the build log that the GROCY_RELEASE arg is clearly passed as v2.6.2: https://ci.linuxserver.io/blue/organizations/jenkins/Docker-Pipeline-Builders%2Fdocker-grocy/detail/master/163/pipeline/131#step-142-log-1

berrnd commented 4 years ago

Should now be fixed, there is also a new branch from now on for releases, see https://github.com/grocy/grocy/issues/698#issuecomment-609072280.

aptalca commented 4 years ago

@berrnd thanks for the heads up. We'll pull from the new location

github-actions[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.