search

linuxserver / docker-grocy

A container for grocy - the ERP application for your kitchen https://grocy.info
GNU General Public License v3.0
333 stars 44 forks source link

Manually change Grocys required PHP version to 7.3 #31

Closed Forceu closed 3 years ago

Forceu commented 3 years ago

linuxserver.io

Description:

Very dirty hotfix so that the image can successfully be built

As PHP 7.4 is not strictly required for Grocy (only set as it is only tested with 7.4) it is safe to manually reduce the version to 7.3 for now. This is not supposed to be a permanent change and should be removed as soon as PHP 7.4 is included in this image.

Benefits of this PR and context:

Version 3.0.1 is supported

How Has This Been Tested?

Building image, PHP 7.3 works fine on my local machine

Source / References:

Issue #30

LinuxServer-CI commented 3 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/grocy/v3.0.1-pkg-830a4a4c-pr-31/index.html https://ci-tests.linuxserver.io/lspipepr/grocy/v3.0.1-pkg-830a4a4c-pr-31/shellcheck-result.xml

edenhaus commented 3 years ago

Thanks @Forceu for this hotfix. I would suggest we use this hotfiy until alpine 3.13 is released.

I can also confirm that this fix is working in my setup