linuxserver / docker-grocy

A container for grocy - the ERP application for your kitchen https://grocy.info
GNU General Public License v3.0
352 stars 43 forks source link

Added dependencies for Grocy and hotfix for PHP<8.0 #47

Closed Forceu closed 3 years ago

Forceu commented 3 years ago

linuxserver.io



Description:

This Pullrequest includes two changes:

As soon as the author fixes the problem or this image is updated to PHP 8.0, the sed statements should be removed!

Benefits of this PR and context:

The build succeeds

How Has This Been Tested?

Building and login to application was sucessful.

Source / References:

Problem is acknowledged in https://github.com/grocy/grocy/issues/1537

Forceu commented 3 years ago

Would close issue #46

LinuxServer-CI commented 3 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/grocy/v3.1.0-pkg-8b4a728d-pr-47/index.html https://ci-tests.linuxserver.io/lspipepr/grocy/v3.1.0-pkg-8b4a728d-pr-47/shellcheck-result.xml

aptalca commented 3 years ago

Thanks for the PR. Can you add a changelog entry to readme-vars.yml as well?

Forceu commented 3 years ago

Thanks for the quick reply, I updated the Readme

LinuxServer-CI commented 3 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/grocy/v3.1.0-pkg-8b4a728d-pr-47/index.html https://ci-tests.linuxserver.io/lspipepr/grocy/v3.1.0-pkg-8b4a728d-pr-47/shellcheck-result.xml