Fix CSRF handling - Githubissues

linuxserver / docker-healthchecks

GNU General Public License v3.0

177 stars 37 forks source link

Fix CSRF handling #115

Closed thespad closed 8 months ago

thespad commented 8 months ago

[x] I have read the contributing guideline and understand that I have made the correct modifications

Description:

Closes #112 and #114

Logic for CSRF setting was wrong and causing inconsistent behaviour. We now default to the value of $SITE_ROOT if nothing is provided, otherwise set to the literal value of the CSRF_TRUSTED_ORIGINS env.

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

LinuxServer-CI commented 8 months ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/healthchecks/v3.1-pkg-b62f1681-dev-d7555e94bb19f6cbd95015b818ed13394c85536d-pr-115/index.html https://ci-tests.linuxserver.io/lspipepr/healthchecks/v3.1-pkg-b62f1681-dev-d7555e94bb19f6cbd95015b818ed13394c85536d-pr-115/shellcheck-result.xml	Tag	Passed
amd64-v3.1-pkg-b62f1681-dev-d7555e94bb19f6cbd95015b818ed13394c85536d-pr-115	✅
arm64v8-v3.1-pkg-b62f1681-dev-d7555e94bb19f6cbd95015b818ed13394c85536d-pr-115	❌