search

linuxserver / docker-healthchecks

GNU General Public License v3.0
178 stars 38 forks source link

Mention port in SITE_ROOT env var #48

Closed axilleas closed 3 years ago

axilleas commented 4 years ago

linuxserver.io

We welcome all PR’s though this doesn’t guarantee it will be accepted.

Description:

It was not apparent that the port should also have been set up. Since the example Docker command and compose file use the port 8000, it would be nice to have this mentioned in the SITE_ROOT description.

Benefits of this PR and context:

Proper configuration of the service.

How Has This Been Tested?

Tested locally.

Source / References:

I had to dig into the official docs to find out about this https://github.com/healthchecks/healthchecks#configuration

LinuxServer-CI commented 4 years ago

I am a bot, here are the test results for this PR: https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/healthchecks/v1.15.0-pkg-50d202d4-pr-48/index.html https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/healthchecks/v1.15.0-pkg-50d202d4-pr-48/shellcheck-result.xml

github-actions[bot] commented 4 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.