linuxserver / docker-healthchecks

GNU General Public License v3.0
177 stars 38 forks source link

Fix for Issue #74 - Super User can't login in v1.22.0 #75

Closed neographophobic closed 3 years ago

neographophobic commented 3 years ago

linuxserver.io



Description:

Change how the super user is created so that they can successfully log in.

Benefits of this PR and context:

Solves Issue #74, and allows the super user created via the environment variables to login

How Has This Been Tested?

  1. Built my own image, using the following instructions, copying in the fixed script
    FROM linuxserver/healthchecks:version-v1.22.0
    COPY 30-config /etc/cont-init.d
  2. Started healthchecks with a docker-compose (the same as referenced in the issue, but using the built image)
  3. Logged in as the super user, and it was successful

Source / References:

Used the script from Healthchecks that creates superusers at https://github.com/healthchecks/healthchecks/blob/master/hc/accounts/management/commands/createsuperuser.py as the basis for the change.

LinuxServer-CI commented 3 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/healthchecks/v1.22.0-pkg-62b9cb81-pr-75/index.html https://ci-tests.linuxserver.io/lspipepr/healthchecks/v1.22.0-pkg-62b9cb81-pr-75/shellcheck-result.xml

github-actions[bot] commented 3 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

neographophobic commented 3 years ago

The issue as far as I can see still occurs. If this is not the appropriate location to file bug reports, can somebody please point me to the more appropriate location.

alex-phillips commented 3 years ago

LGTM, thanks.