Install Apprise as project dependency (introduced in v1.24.0) - Githubissues

linuxserver / docker-healthchecks

GNU General Public License v3.0

177 stars 38 forks source link

Install Apprise as project dependency (introduced in v1.24.0) #82

Closed immanuelfodor closed 2 years ago

immanuelfodor commented 3 years ago

Install Apprise as project dependency in parallel with https://github.com/healthchecks/healthchecks/issues/581 and https://github.com/healthchecks/healthchecks/commit/b77c54f6655a29f648576e5d5fff341d00576c04 that was released in https://github.com/healthchecks/healthchecks/releases/tag/v1.24.0

[x] I have read the contributing guideline and understand that I have made the correct modifications

Description:

Healthcheck's Apprise integration depends on the apprise pip package, and it's now included in the upstream Dockerfile by default. This change was introduced in v1.24.0, this PR keeps the LS image in parallel with it. Also added the relevant upstream environment variable to the readme (not used in the Dockerfile but consumed by the settings.py).

Benefits of this PR and context:

Apprise integration can now be used without dirty runtime hacks or custom built dockerfiles.

How Has This Been Tested?

Ran the docker build command on Ubuntu, the pip install was fine.

Source / References:

Original issue: https://github.com/healthchecks/healthchecks/issues/581
Fixed in commit: https://github.com/healthchecks/healthchecks/commit/b77c54f6655a29f648576e5d5fff341d00576c04
Released in v1.24.0: https://github.com/healthchecks/healthchecks/releases/tag/v1.24.0
Env var reference: https://healthchecks.io/docs/self_hosted_configuration/

LinuxServer-CI commented 3 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/healthchecks/v1.24.1-pkg-6bcf9af9-pr-82/index.html https://ci-tests.linuxserver.io/lspipepr/healthchecks/v1.24.1-pkg-6bcf9af9-pr-82/shellcheck-result.xml

immanuelfodor commented 2 years ago

Who has permission to merge this PR? Maybe gently nudging @alex-phillips helps? :)

immanuelfodor commented 2 years ago

Hellooo, anyone?

immanuelfodor commented 2 years ago

How should I get this merged? 😃

thespad commented 2 years ago

Can you update the readme as it now has a merge conflict with https://github.com/linuxserver/docker-healthchecks/pull/84

immanuelfodor commented 2 years ago

Of course, done

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/healthchecks/v1.25.0-pkg-1d4cf52c-pr-82/index.html https://ci-tests.linuxserver.io/lspipepr/healthchecks/v1.25.0-pkg-1d4cf52c-pr-82/shellcheck-result.xml