search

linuxserver / docker-hedgedoc

GNU General Public License v3.0
43 stars 7 forks source link

Add instructions to create volume for uploads #22

Closed thomaswucher closed 2 years ago

thomaswucher commented 2 years ago

linuxserver.io

Description:

This fixes #18. Leaving out the docker volume for uploads will remove all uploaded attachments on container updates, causing a loss of production data.

Benefits of this PR and context:

Data loss is bad so we should prevent it.

How Has This Been Tested?

I restarted the container and I still have my uploads.

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/hedgedoc/1.9.0-pkg-609eb384-pr-22/index.html https://ci-tests.linuxserver.io/lspipepr/hedgedoc/1.9.0-pkg-609eb384-pr-22/shellcheck-result.xml

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/hedgedoc/1.9.0-pkg-609eb384-pr-22/index.html https://ci-tests.linuxserver.io/lspipepr/hedgedoc/1.9.0-pkg-609eb384-pr-22/shellcheck-result.xml

thomaswucher commented 2 years ago

Ping @aptalca

Roxedus commented 2 years ago

This is not the way to change the readme, it will not last. there's a short explanation in the contributing file you claim to have read.

Roxedus commented 2 years ago

Sorry for trying my best to keep up with all prs and issues?

thomaswucher commented 2 years ago

Thanks for taking a look at this, I know you are doing this for free and that's awesome. Sometimes it can just be a little bit frustrating, when no one seems to care (even if that's not true, I know).

aptalca commented 2 years ago

Just being honest. . . Those types of comments generally make me push those issues/PRs further down on my ridiculously long to do list. We are all volunteers here and we all have jobs and lives outside of this.

But I'm just one person. Maybe someone else on the team will be motivated to look into it.

aptalca commented 2 years ago

posted my message before I saw your last one. In any case, we are not ignoring. We just have a really long list of issues to deal with: https://github.com/orgs/linuxserver/projects/3

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/hedgedoc/1.9.0-pkg-609eb384-pr-22/index.html https://ci-tests.linuxserver.io/lspipepr/hedgedoc/1.9.0-pkg-609eb384-pr-22/shellcheck-result.xml