linuxserver / docker-jackett

GNU General Public License v3.0
390 stars 96 forks source link

Inconsistent documentation on auto-updates #131

Closed pvillano closed 1 year ago

pvillano commented 1 year ago

linuxserver.io


Desired Behavior

Consistency between readme.md, itself, and docker-jackett/root/etc/services.d/jackett/run.

Probably removal of AUTO_UPDATE environment variable from README.md and run; --NoUpdates always on

Current Behavior

Inconsistent information regarding autoupdates on master branch

In the development branch,

  1. the documentation for the auto-update environment variable is removed from readme.md,
  2. but docker-jackett/root/etc/services.d/jackett/run still reads the environment variable
  3. and defaults to auto-updating
  4. and recommends disabling auto-updates in the web ui
  5. and has the standard post-amble about how you should just update the container

Alternatives Considered

going outside for a bit

github-actions[bot] commented 1 year ago

Thanks for opening your first issue here! Be sure to follow the bug or feature issue templates!

aptalca commented 1 year ago

We usually don't allow updating inside the container unless it is absolutely necessary (ie. nextcloud, plex beta, etc.). Jackett for a long time did not allow updates inside the container. But then the upstream dev requested and insisted we add it because it made it easier for their support team. So we did. The readme on the master branch is accurate. It seems we neglected to update the readme on the develop branch when we added that functionality in.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.