search

linuxserver / docker-jackett

GNU General Public License v3.0
394 stars 95 forks source link

Add env var to allow pre-build version of Jackett installation #32

Closed welcoMattic closed 7 years ago

welcoMattic commented 7 years ago

Fixes #30

LinuxServer-CI commented 7 years ago

Can an admin please whisper to jenkins to test this PR.

sparklyballs commented 7 years ago

just no

sparklyballs commented 7 years ago

building different version by ENV var etc just begs the question as to why you don't just change the line in the git lookup and build locally

welcoMattic commented 7 years ago

Because I'm using it in a docker-compose stack. It should be an option to allow user of this image to install a pre-build version of Jackett. I'm not changing the default, I'm adding an option. With this possibility, everyone can choose, and pre-build version allows us to have latest trackers list on Jackett.

Please don't close savagely PR without any discussion, it's not respectful.

sparklyballs commented 7 years ago

which you still have to build locally.

hence why not just change the Dockerfile locally and build locally rather than force a change on the whole repo to suit your personal environment.

welcoMattic commented 7 years ago

I thought about that, but as docker-jackett is open source, I prefer to submit with a PR to share it. But, obviously you really don't want any change here, so let me do this for my personal use.

I just want to precise that my changes don't affect any default behaviour of the image, it's just adding an option. It's not BC break. It's not a total rewriting of the Dockerfile.

sparklyballs commented 7 years ago

open source does not mean accept all PR's

welcoMattic commented 7 years ago

Of course, it doesn't mean accept all PR's, but generally PR adding not useless options are accepted, or discussed. Not first closed.

Enough for me, I'll use my fork.

CHBMB commented 7 years ago

Whilst I accept the PR is not a bad idea per se, it does mean it's added complexity that we have to support, so we tend to favour keeping things simple. Not everyone is a technically minded as yourself @welcoMattic we have a lot less tech savvy users from different platforms you see.