linuxserver / docker-jackett

GNU General Public License v3.0
394 stars 95 forks source link

add --NoUpdates command line flag #44

Closed kaso17 closed 6 years ago

kaso17 commented 6 years ago

Starting with version v0.8.676 jackett has a new command line option --NoUpdates which will prevent any kind of self updates. I suggest you add it to the docker init options to prevent the 100% CPU bug (See #34).

sparklyballs commented 6 years ago

@kaso17 thanks for the heads up and i've put in a PR #45

ellmout commented 6 years ago

hi @kaso17 and @sparklyballs since this update, Jackett can't be updated easily. You need to rebuild the container each time you want to update to the last version, no just a restart 😞 .

j0nnymoe commented 6 years ago

@elliotvr This is no different to all our other containers.

ellmout commented 6 years ago

@j0nnymoe yes, but Sonarr & Radarr can self-update. Here, you can no longer update Jackett ! Sonarr & Radarr get updated every month Jackett get updated every two days (for trackers...), so rebuild your container every two days to access your tracker is not cool !

sparklyballs commented 6 years ago

updating an app in a running container is recipe for breakage

this line was put in because the update checker was consuming 100% of system resources on host OS for a very large number of our users

j0nnymoe commented 6 years ago

Use docker-compose or something similar to manage your containers for easy rebuilding/updating.

ellmout commented 6 years ago

I'm on Synology NAS, so i'm using Synology Docker interface. I will try docker-compose. Thx !

florianfranconi commented 6 years ago

Hi, I have the same problem on my Synology docker. Impossible to make updates on jackett I have the error:"Info Updates are disabled via --NoUpdates.". I uninstalled and reinstalled the container docker and I still have the same error. If someone has found a solution...

sparklyballs commented 6 years ago

updates via the webui have been deliberately disabled

florianfranconi commented 6 years ago

Ah, it's embarrassing... How do I get the latest version of the coup? Because I have the last docker container available.

sparklyballs commented 6 years ago

we build a new version weekly on friday evenings around 11pm uk time

ellmout commented 6 years ago

I'm now using docker-compose to configure my containers, ssh & root.

version: '2'
services:
    jackett:
        # image: linuxserver/jackett:latest
        build: https://github.com/linuxserver/docker-jackett.git
        container_name: jackett
        restart: always
        ports:
            - 9117:9117
        environment:
            - TZ=Europe/Paris
            - PGID=1001
            - PUID=1001
        volumes:
            - /volume1/docker/Jackett:/config

and use build instead of image.

florianfranconi commented 6 years ago

Thank you for your feedback, so I'll wait for the update tonight. If it doesn't work, I will test the solution of @elliotvr. To use docker-component I need to create a file docker-component. yml at the root of my synology? I am not experienced with Docker, I discover using the Synology interface.

sparklyballs commented 6 years ago

@kaso17

i've setup a ping to our jenkins server if you're interested

contact us here and i can send you a DM https://discord.gg/YWrKVTn

florianfranconi commented 6 years ago

Hello, I still have the problem of updates even with the latest version of tonight :(

sparklyballs commented 6 years ago

updates via the webui have been disabled

florianfranconi commented 6 years ago

Oh, all right! Why this choice? So how can we update jackett easily?

sparklyballs commented 6 years ago

read ^^^^

florianfranconi commented 6 years ago

Sorry, I don't understand. So to update Jackett you have to update the container with the version you release every Friday?

kaso17 commented 6 years ago

The docker container should now be automatically rebuild on every jackett release, so it should be always up to date.

sparklyballs commented 6 years ago

yep we and the jackett dev team have worked together to ensure our docker image should always be up to date and you can get the newest version by pulling the image and rebuilding the container

vinchi007 commented 6 years ago

above @elliotvr build vs image docker will still pull docker "run" config file which has -UpUpgrade flag in it. @sparklyballs if you work closely with jackett team, can you devise an automatic docker container upgrade solution? presently it requires going into rancher os and doing container upgrade manually. kind of defeats the purpose of git fetch automation with autoupdates

aptalca commented 6 years ago

@vinchi007 automatic docker container update has nothing to do with either jackett or linuxserver. We provide a new docker image as soon as a new version of jackett is released. It is your docker manager's responsibility to update the image and recreate the container. There are plenty of solutions for that. Docker compose does it through a pull and an up -d, rancheros will let you click on an update button, watchtower allows you to set schedules where it automatically updates them, etc.

Our docker images are meant to be static images. They are properly versioned. The containers are ephemeral. The idea is that whoever creates a container on whatever os and environment, should have the same exact experience as long as they use the same image. Auto updating packages inside that image defeats that idea.

darkbroodzed commented 6 years ago

@aptalca so now you enforce everyone who use docker image to download full image and rebuild it every time, not just download new files and restart image. Great victory over common sense.

aptalca commented 6 years ago

@darkbroodzed Not rebuild, but recreate. We build the images and push to the hub. All you would do is update the image (docker pull) and recreate the container

That's how docker containers were meant to be utilized and all of our images have worked that way for a long time.

If you don't like it you're welcome to install jackett yourself and let it update, or build your own docker image. Everything is open source

sparklyballs commented 6 years ago

@darkbroodzed common sense is subjective at best

is it common sense to have a container that updates itself and then breaks because update x needs a dependency that isn't in the container ?

is it common sense that we have a multitude of people with the same base container version but totally different versions of the app and we have support nightmare scenario ?

containers as @aptalca said already, are meant to be ephemeral

the no updates flag was added because the container was restarting the app when updates were available and consuming host resources and we thought it "common sense" to add the flag

Ansem93 commented 5 years ago

Is this bug resolved? Can I remove the --noupdate flag now? I have the version 10.422