search

linuxserver / docker-jackett

GNU General Public License v3.0
395 stars 95 forks source link

Automatic builds on every release using outdated tag #54

Closed h45rd closed 6 years ago

h45rd commented 6 years ago

Thanks for this docker.

Due to github API's handling of pre-releases this line in your dockerfile pulls the wrong tag if it is marked as pre-release.

Would probably be better to use https://api.github.com/repos/Jackett/Jackett/tags for pulling tags. If you do not want to use pre-releases for the main tag, could you alternatively provide a dev tag for the bleeding edge and limit automatic builds of the main tag to new releases?

Right now every tagged (pre-)release in the Jackett repo triggers a build of the main tag, using the same outdated v0.9.41, as v0.10.x releases are tagged as pre-releases.

sparklyballs commented 6 years ago

we get a ping from jackett everytime they make a release, be it pre-release or otherwise.

our jenkins builds the image on that ping.

we currently have no plans to use pre-release versions

0.9.4.1 is not "outdated" by any stretch of the imagination, it is the latest release.

h45rd commented 6 years ago

Wow.. you are fast :) Understood.

Didn't mean to criticize or trivialize your work. Just didn't realize building on every release, even when it is not used due to being a pre-release, would be intentional. Might be a while to the next "full" release due to the switch to kestrel, though.

Best, h45rd

bruvv commented 5 years ago

there is a new latest release but nothing got update (8 days ago)

sparklyballs commented 5 years ago

@d1slact0r

screen shot 2018-09-14 at 09 52 21

github release

screen shot 2018-09-14 at 09 52 28

screen shot of my jackett container showing the version.

as you can see it is up to date. i suggest you update your image.

bruvv commented 5 years ago

sorry my watchtower crashed restart and all is updated ;)