linuxserver / docker-jackett

GNU General Public License v3.0
395 stars 95 forks source link

rebase to ubuntu vanilla, using .net core builds of jackett #75

Closed sparklyballs closed 5 years ago

sparklyballs commented 5 years ago

linuxserver.io

Thanks, team linuxserver.io

sparklyballs commented 5 years ago

well that makes no sense because i built everything locally and span them up with no probs.

aarch64

Screenshot 2019-03-10 at 11 52 28

armhf

Screenshot 2019-03-10 at 11 53 13

x86-64

Screenshot 2019-03-10 at 11 54 41

sparklyballs commented 5 years ago

nvm, missed the qemu stuff on armxx Dockerfiles.

LinuxServer-CI commented 5 years ago

I am a bot, here are the test results for this PR https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/jackett/v0.11.1-pkg-08f3e91a-pr-75/index.html

sparklyballs commented 5 years ago

i've been using the preview-dev branch ,i.e. netcore, that @thelamer suggested in the issue i raised last night.

i can't find anything wrong and it's a drop-in replacement with existing data from the mono version.

sparklyballs commented 5 years ago

@thelamer

this will get the latest tag, but it doesn't differentiate between release and pre-release, it gets the latest tag regardless.

JACKETT_RELEASE=$(curl -sX GET "https://api.github.com/repos/Jackett/Jackett/tags" \
| jq -r .[0].name)

while it will fetch pre-releases, that the master branch will not, if the latest tag is a release, then the dev branch and the master branch will be the same tag.

thelamer commented 5 years ago

you can use:

JACKETT_RELEASE=$(curl -sX GET "https://api.github.com/repos/Jackett/Jackett/releases" \
| jq -r 'first(.[] | select(.prerelease == true)) | .tag_name')

But I think @aptalca wants to ingest the first in the array jq -r '.[0]' as their stable releases can technically be ahead of their pre releases at times.

Sorry when I said tag I was referring to the releases endpoint tag_name, not literal tags. That endpoint is fucked, they do not sort it by date so you cannot trust it's output order.