search

linuxserver / docker-jellyfin

GNU General Public License v3.0
647 stars 97 forks source link

Ensure hardware acceleration devices have proper group permissions #112

Closed metronidazole closed 2 years ago

metronidazole commented 3 years ago

linuxserver.io

Description:

This fixes issue #111 (and probably a lot of cases of #26 ) by ensuring all detected hardware acceleration devices have group permissions set (g+rwx). This is required for hardware acceleration to work if the docker host system does not have any group permissions set for them (these get replicated into the docker container)

Benefits of this PR and context:

Fixes hardware acceleration for many users, including those with synology devices which by default don't have group permissions set for the intel quicksync device (/dev/dri/renderD128)

How Has This Been Tested?

Yes - single line of code.

Source / References:

See #111

LinuxServer-CI commented 3 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/jellyfin/10.7.5-1-pkg-fd286eef-pr-112/index.html https://ci-tests.linuxserver.io/lspipepr/jellyfin/10.7.5-1-pkg-fd286eef-pr-112/shellcheck-result.xml

aptalca commented 3 years ago

I don't believe you can change device permissions from inside the container unless it's running with --privileged

metronidazole commented 3 years ago

I don't believe you can change device permissions from inside the container unless it's running with --privileged

You can using CgroupPermissions which is what a number of people use with synology devices.

See https://www.reddit.com/r/jellyfin/comments/exepia/synology_users_how_to_enable_hardware/fhv32z5/

I wouldn't have submitted this if it didn't work.

github-actions[bot] commented 3 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.