Closed istvan-andrasi closed 3 years ago
This would create a support nightmare with little benefit
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/jellyfin/10.7.5-1-pkg-3da03dfc-pr-113/index.html https://ci-tests.linuxserver.io/lspipepr/jellyfin/10.7.5-1-pkg-3da03dfc-pr-113/shellcheck-result.xml
This would create a support nightmare with little benefit
Please elaborate. It only affects the four environment variables which had no effect until now, and by default they have the same values they used to have.
Thanks.
The more users deviate from the standardized config, the harder it is for us to help troubleshoot when they have issues.
Okay thanks.
Description:
This change let's me override the server config with JELLYFIN_*_DIR env vars, so I'm free to relocate specific Jellyfin dirs instead of being forced into a predefined structure.
Also, I expect the env variables mentioned by the Jellyfin documentation to work with this image as well.
Benefits of this PR and context:
JELLYFIN_*_DIR env variables allow the users to relocate the data, config, cache and log directories, if they want to. If those variables are not specified, it works the same way as before.
How Has This Been Tested?
Try to use configuration env vars:
The logs clearly show they are not picked up:
Run
bash
in container and make proposed change to startup script.Restart container:
Log shows the environment variables are picked up:
Source / References:
N/A