Fix documentation on intel hw accel, in sync with official docs

Oberau commented 1 year ago

[x] I have read the contributing guideline and understand that I have made the correct modifications

Description:

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

Oberau commented 1 year ago

i just read you rather have an issue for doc changes, will do that next time.

Roxedus commented 1 year ago

This is a good PR, please do the changes in the correct file, as outlined in the contributing file.

LinuxServer-CI commented 1 year ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/jellyfin/10.8.8-1-pkg-faaade5c-pr-175/index.html https://ci-tests.linuxserver.io/lspipepr/jellyfin/10.8.8-1-pkg-faaade5c-pr-175/shellcheck-result.xml

Oberau commented 1 year ago

I have made the changes to the correct file now. Can you discard changes to wrong file when processing this pull request?

LinuxServer-CI commented 1 year ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/jellyfin/10.8.8-1-pkg-faaade5c-pr-175/index.html https://ci-tests.linuxserver.io/lspipepr/jellyfin/10.8.8-1-pkg-faaade5c-pr-175/shellcheck-result.xml

aptalca commented 1 year ago

Actually, this is incorrect for our image. Our readme already lists the correct mount point.

Oberau commented 1 year ago

i have tried your image this morning with the mount point as provided in the readme, it did not work. Only after providing the updated mounts as provided in official docs, and it this PR did it work.

Im streaming right now with this compose config:

Oberau commented 1 year ago

okay more testing i find it works with the more general /dev/dri, it turns out my first to get it working i used wrong devices syntax. This issue was because no compose example for adding devices is given in your docs. So there is still a fix needed by showing the right optional parameters in the README for exposing the devices in dockercompose

aptalca commented 1 year ago

Feel free to add a blurb for the compose syntax, but we only support mapping /dev/dri and not specific devices, because that would break the permission changes we do that's required for a lot of nas users.

And no links to the official docs because they are not applicable here for the above mentioned reason.

Oberau commented 1 year ago

isn't the fix to go into readme-vars and put opt_param_device_map: true so your pipeline renders these options in the docs?

My github workspaces seems to be having issues with git so unable to changing anything in this PR. Could you do this fix and close this PR?

linuxserver / docker-jellyfin