search

linuxserver / docker-jellyfin

GNU General Public License v3.0
607 stars 91 forks source link

[FEAT] Change owner of web files to PUID #182

Closed raphpa closed 1 year ago

raphpa commented 1 year ago

Is this a new feature request?

Wanted change

Changing the owner of the included web interface files to the given PUID/PGID that jellyfin runs with.

Reason for change

The plugin Jellyscrub needs a custom script on the player page to work. For that it injects itself into the index.html file on jellyfin start. This only works if the container is started with root for PUID/PGID, else the jellyfin process is not allowed to modify the index.html file.

Proposed code change

Changing the owner of /usr/share/jellyfin/web to PUID/PGID on container start.

github-actions[bot] commented 1 year ago

Thanks for opening your first issue here! Be sure to follow the bug or feature issue templates!

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

marouamghar commented 1 year ago

I suppose a chmod after creating the files would fix the issue!

Silvenga commented 1 year ago

@raphpa @marouamghar created a pr for this. I believe this would fully resolve your pain points?

marouamghar commented 1 year ago

@Silvenga i think so. I looked at the PR, are you planning on converting it to a mod?

raphpa commented 1 year ago

Not sure why chowning takes that much time, but a RUN chmod -R 666 /usr/share/jellyfin/web in Dockerfile would also let the plugins inject itself.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

Silvenga commented 1 year ago

TBH @marouamghar - I stopped using the LSIO image since I needed to debug the internals of JellyFin. I've built my own https://github.com/silvenga-docker/jellyfin-debug.

Through this, I've separated the frontend and backend and I'm having Nginx rewrite the index.html file to inject the script in.

https://github.com/silvenga-docker/jellyfin-debug/blob/85a17a83f54fe3e0d02dc51b442a296c2aec20cd/src/jellyfin-web/rootfs/etc/nginx/conf.d/default.conf#L6-L14

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 11 months ago

This issue is locked due to inactivity