[FEAT] Un-hardcode the environmental parameters

fsackur commented 11 months ago

Is this a new feature request?

[X] I have searched the existing issues

Wanted change

Env vars are ignored, and incorrect values are shown in the logs.

e.g. in docker-compose:

      - JELLYFIN_DATA_DIR=/var/lib/jellyfin/data
      - JELLYFIN_CACHE_DIR=/var/lib/jellyfin/cache

log shows:

Environment Variables: ["[JELLYFIN_CACHE_DIR, /config/cache]", "[JELLYFIN_DATA_DIR, /data]"

I see #204. @aptalca shut down that discussion. If I phrase this as a feature request, could that person please not hammer me?

Reason for change

I don't want cache or logs on /
- Jellyfin rages on first run if the cache folder already exists, making it a chore to create symlinks on the host
- ...and I run docker so I don't have to live in a maze of twisty passages
I don't want the next poor user to lose time trying to figure out this bug
It's a sin to lose basic functionality from the official image

Proposed code change

root/etc/s6-overlay/s6-rc.d/svc-jellyfin/run

JELLYFIN_DATA_DIR=${JELLYFIN_DATA_DIR:-/config/data} \
JELLYFIN_CONFIG_DIR=${JELLYFIN_CONFIG_DIR:-/config} \
JELLYFIN_LOG_DIR=${JELLYFIN_LOG_DIR:-/config/log} \
JELLYFIN_CACHE_DIR=${JELLYFIN_CACHE_DIR:-/config/cache}  \
JELLYFIN_WEB_DIR=${JELLYFIN_WEB_DIR:-/usr/share/jellyfin/web}

github-actions[bot] commented 11 months ago

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

fsackur commented 11 months ago

Please confirm a PR is acceptable with the code fix and an update to README.md. If not, then go ahead and close.

LinuxServer-CI commented 9 months ago

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

nikp123 commented 8 months ago

Is there ANY sane reason to hard-code these??? I am having trouble migrating from jellyfin/jellyfin because of this.

aptalca commented 8 months ago

Yes, we have reasons.

We don't officially support migrations between images of different devs. With that said, migration is fairly straightforward as long as you set up the new container with a different config folder first, so you can see the folder structure the new image expects. Then it's a matter of matching your existing data to the new format and restarting/recreating the container

LinuxServer-CI commented 7 months ago

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 4 months ago

This issue is locked due to inactivity

linuxserver / docker-jellyfin