fix: take ownership of plugin directories

linuxserver / docker-jellyfin

GNU General Public License v3.0

600 stars 92 forks source link

fix: take ownership of plugin directories #214

Closed ReenigneArcher closed 10 months ago

ReenigneArcher commented 10 months ago

[x] I have read the contributing guideline and understand that I have made the correct modifications

Description:

Benefits of this PR and context:

This PR applies correct permissions to the jellyfin plugins directory, but more specifically the plugin configuration directories. Plugins for Jellyfin do not, and should not, supply the configuration directory, and should not be responsible for applying permissions on it, as if multiple plugins were added with the docker mod method, they could conflict with each other.

How Has This Been Tested?

I have not tested, the change is straight forward.

Source / References:

https://github.com/linuxserver/docker-mods/issues/753#issuecomment-1698198279

LinuxServer-CI commented 10 months ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/jellyfin/10.8.10-1-pkg-f3c3b90b-dev-8a8c8e695cb1e6a3eccab3db38b866f64adac72a-pr-214/index.html https://ci-tests.linuxserver.io/lspipepr/jellyfin/10.8.10-1-pkg-f3c3b90b-dev-8a8c8e695cb1e6a3eccab3db38b866f64adac72a-pr-214/shellcheck-result.xml	Tag	Passed
amd64-10.8.10-1-pkg-f3c3b90b-dev-8a8c8e695cb1e6a3eccab3db38b866f64adac72a-pr-214	✅
arm64v8-10.8.10-1-pkg-f3c3b90b-dev-8a8c8e695cb1e6a3eccab3db38b866f64adac72a-pr-214	✅

ReenigneArcher commented 10 months ago

Any feedback?

thespad commented 10 months ago

I don't see any issue with this in priciple ~~how many files make up the average plugin? My only concern would be startup performance impact if the user has thousands of files under the plugin folder structure.~~ Ignore that, we're not doing a recursive chown.

Please add an entry to the readme-vars changelog and then I'm happy to approve and merge.

ReenigneArcher commented 10 months ago

@thespad Thanks for the feedback. I added a changelog entry.

LinuxServer-CI commented 10 months ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/jellyfin/10.8.10-1-pkg-a1bf5c83-dev-f0f6dffac533c8089a58e2c98b253bb4cc8c25b1-pr-214/index.html https://ci-tests.linuxserver.io/lspipepr/jellyfin/10.8.10-1-pkg-a1bf5c83-dev-f0f6dffac533c8089a58e2c98b253bb4cc8c25b1-pr-214/shellcheck-result.xml	Tag	Passed
amd64-10.8.10-1-pkg-a1bf5c83-dev-f0f6dffac533c8089a58e2c98b253bb4cc8c25b1-pr-214	✅
arm64v8-10.8.10-1-pkg-a1bf5c83-dev-f0f6dffac533c8089a58e2c98b253bb4cc8c25b1-pr-214	✅