search

linuxserver / docker-librespeed

GNU General Public License v3.0
76 stars 9 forks source link

[FEAT] Add parameter "enable_id_obfuscation" to environment variables #29

Closed DenDeXTeR51 closed 8 months ago

DenDeXTeR51 commented 11 months ago

Is this a new feature request?

Wanted change

Want to set parameter "enable_id_obfuscation" from _results/telemetrysettings.php via docker environment variables

Reason for change

If I want to change this parameter in _results/telemetrysettings.php I had to re-write file _telemetrysettings.php. It will be easier if this parameter can be set as all other parameters (DB_,IPINFO_APIKEY, etc) via env variables.

Proposed code change

No response

aptalca commented 11 months ago

It's already set: https://github.com/linuxserver/docker-librespeed/blob/master/root/etc/s6-overlay/s6-rc.d/init-librespeed-config/run#L43

DenDeXTeR51 commented 11 months ago

But its hardcode to 'true'. I want to set 'false' via docker evironemnt variables.

aptalca commented 11 months ago

We honestly didn't think anyone would want it off.

You can customize the container via https://www.linuxserver.io/blog/2019-09-14-customizing-our-containers

DenDeXTeR51 commented 11 months ago

For example I use this image in AWS Elastic Container Service, and to change this parameter I need to add custom scripts that will be mounted to container to change only 1 parameter on every start of container instance... I can rebuild container and stored it in my private repo (only because of 1 parameter) OR I need to generate whole _results/telemetrysettings.php thta will be mounted to _results/telemetrysettings.php mount file, and your script that set Vars inside it, is not needed anymore. The best part of linuxserver/librespeed container that it has almost all parameters from _results/telemetrysettings.php already in Env Vars.. (except enable_id_obfuscation :( ) and people dont need to modify/rebuild and store custme images.

drizuid commented 10 months ago

We do not plan to add additional envvars, but you can customize as you see fit per aptalca's comment.

LinuxServer-CI commented 9 months ago

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 7 months ago

This issue is locked due to inactivity