search

linuxserver / docker-manyfold

GNU General Public License v3.0
3 stars 0 forks source link

Keep required Ruby version at 3.3.3 for now #4

Closed thespad closed 2 months ago

thespad commented 2 months ago

linuxserver.io

Description:

Alpine repo is still on 3.3.3 and might stay there. Edge is also still 3.3.3 but might be the best option if upstream project continues to bump Ruby requirement.

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

Floppy commented 2 months ago

In general upstream will indeed keep bumping to latest Ruby as long as Alpine has the version, so yeah, if you need to stick on 3.3.3, this makes sense :)

thespad commented 2 months ago

In general upstream will indeed keep bumping to latest Ruby as long as Alpine has the version, so yeah, if you need to stick on 3.3.3, this makes sense :)

Has something changed in 0.77 WRT auth? I'm getting a 403 on http://localhost:3214/ with our CI tests

Floppy commented 2 months ago

In general upstream will indeed keep bumping to latest Ruby as long as Alpine has the version, so yeah, if you need to stick on 3.3.3, this makes sense :)

Has something changed in 0.77 WRT auth? I'm getting a 403 on http://localhost:3214/ with our CI tests

Ah, yes, auth is no longer required for all pages, because it can now handle public content. I'd expect it to be more permissive though, not less...

Floppy commented 2 months ago

Ah, looking at the build error, it looks like it's getting permission denied on new library setup when first run? I will check what it's doing, I think that might be my bug in single-user mode,

thespad commented 2 months ago

Ah, looking at the build error, it looks like it's getting permission denied on new library setup when first run? I will check what it's doing, I think that might be my bug in single-user mode,

Yeah, this is clean run, CI testing, passing it SECRET_KEY_BASE=placeholder & DATABASE_URL=sqlite3:/config/manyfold.sqlite3 with our CI redis mod installed locally.

Floppy commented 2 months ago

Yep, this is my fault. Thanks for pointing it out!

Just released a patch version to fix it, v0.77.1: https://github.com/manyfold3d/manyfold/releases/tag/v0.77.1

LinuxServer-CI commented 2 months ago
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/manyfold/v0.77.1-pkg-a76e1b4c-dev-b5922f4df638395ca6559c3b13d5cc3695d62bdd-pr-4/index.html https://ci-tests.linuxserver.io/lspipepr/manyfold/v0.77.1-pkg-a76e1b4c-dev-b5922f4df638395ca6559c3b13d5cc3695d62bdd-pr-4/shellcheck-result.xml Tag Passed
amd64-v0.77.1-pkg-a76e1b4c-dev-b5922f4df638395ca6559c3b13d5cc3695d62bdd-pr-4 ✅
arm64v8-v0.77.1-pkg-a76e1b4c-dev-b5922f4df638395ca6559c3b13d5cc3695d62bdd-pr-4 ❌
LinuxServer-CI commented 2 months ago
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/manyfold/v0.77.3-pkg-a76e1b4c-dev-b5922f4df638395ca6559c3b13d5cc3695d62bdd-pr-4/index.html https://ci-tests.linuxserver.io/lspipepr/manyfold/v0.77.3-pkg-a76e1b4c-dev-b5922f4df638395ca6559c3b13d5cc3695d62bdd-pr-4/shellcheck-result.xml Tag Passed
amd64-v0.77.3-pkg-a76e1b4c-dev-b5922f4df638395ca6559c3b13d5cc3695d62bdd-pr-4 ✅
arm64v8-v0.77.3-pkg-a76e1b4c-dev-b5922f4df638395ca6559c3b13d5cc3695d62bdd-pr-4 ❌