linuxserver / docker-mariadb

GNU General Public License v3.0
212 stars 46 forks source link

Upgrade #112

Closed nemchik closed 1 year ago

nemchik commented 1 year ago
LinuxServer-CI commented 1 year ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/mariadb/10.6.10-r0-pkg-42d0487d-pr-112/index.html https://ci-tests.linuxserver.io/lspipepr/mariadb/10.6.10-r0-pkg-42d0487d-pr-112/shellcheck-result.xml

github-actions[bot] commented 1 year ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

LinuxServer-CI commented 1 year ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/mariadb/10.6.10-r0-pkg-59050081-pr-112/index.html https://ci-tests.linuxserver.io/lspipepr/mariadb/10.6.10-r0-pkg-59050081-pr-112/shellcheck-result.xml

LinuxServer-CI commented 1 year ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/mariadb/10.6.10-r0-pkg-59050081-pr-112/index.html https://ci-tests.linuxserver.io/lspipepr/mariadb/10.6.10-r0-pkg-59050081-pr-112/shellcheck-result.xml

nemchik commented 1 year ago

image

Reworked to have the upgrade check run after svc-mariadb is ready. It is also now completely silent unless an upgrade is needed (and the MYSQL_ROOT_PASSWORD variable contains a valid root password).

The issue with the initial attempt was the upgrade logic being wedged into the initdb logic and trying to start mariadb without a password in order to then check if an upgrade was needed.

I have tested lspipepr/mariadb:amd64-10.6.10-r0-pkg-59050081-pr-112 and confirmed it works as expected.

LinuxServer-CI commented 1 year ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/mariadb/10.6.10-r0-pkg-59050081-pr-112/index.html https://ci-tests.linuxserver.io/lspipepr/mariadb/10.6.10-r0-pkg-59050081-pr-112/shellcheck-result.xml