search

linuxserver / docker-mods

Documentation and Examples of base container modifications
GNU General Public License v3.0
1.02k stars 265 forks source link

[FEAT] Support explicit digest in mod list #922

Open qlonik opened 2 months ago

qlonik commented 2 months ago

Is this a new feature request?

Name of mod

mod-scripts (general)

Wanted change

Add support for specifying digests in the list of mods, e.g.:

DOCKER_MODS=ghcr.io/linuxserver/mods:universal-calibre-v7.12.0@sha256:e8aad70cc71c65587e28711ab16a0ffa1bbcb707b462a6313b721f7622529be3|ghcr.io/linuxserver/mods:lazylibrarian-ffmpeg@sha256:5083d9f2bdfcb27edf65a55e7c05d0ae8ce309d02d5f0cdc83bfe8e95c942dd4

Reason for change

This provides extra enforcement of the mod version.

I have renovate bot manage these sha256 digests for me: https://github.com/qlonik/musical-parakeet/blob/90396d3c0287656ad87c97e522a6d483f83ccf37/kubernetes/main/apps/default/lazylibrarian/app/helmrelease.yaml#L47-L60, so it is not a very big burden. I suspect other people might not have a setup like this, but it would be helpful to support explicit digests.

Proposed code change

No. It seems that either get_blob_sha needs to change or the call before this function needs to check for presence of sha256 in tag.

LinuxServer-CI commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.