linuxserver / docker-netbox

GNU General Public License v3.0
79 stars 17 forks source link

Added remote authentication environment variables #13

Closed mattycourtney closed 3 years ago

mattycourtney commented 3 years ago

linuxserver.io



Description:

Added environment variables to control NetBox's remote authentication configuration parameters

Benefits of this PR and context:

This PR enables users of the container image to control NetBox's remote authentication configuration parameters using environment variables.

Configuring remote authentication facilitates SSO via reverse proxy servers that add a HTTP header to indicate the authenticated user's identity.

How Has This Been Tested?

Source / References:

LinuxServer-CI commented 3 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/netbox/v2.10.4-pkg-0a2c9289-pr-13/index.html https://ci-tests.linuxserver.io/lspipepr/netbox/v2.10.4-pkg-0a2c9289-pr-13/shellcheck-result.xml

mattycourtney commented 3 years ago

I'm really keen to see this get merged, as I use REMOTE_AUTH to SSO to Netbox hosted behind an identity aware proxy. Please let me know if there's any more detail I can provide within this PR that will aid your evaluation.

github-actions[bot] commented 3 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

mattycourtney commented 3 years ago

bump

LinuxServer-CI commented 3 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/netbox/v2.10.6-pkg-4cdd4aed-pr-13/index.html https://ci-tests.linuxserver.io/lspipepr/netbox/v2.10.6-pkg-4cdd4aed-pr-13/shellcheck-result.xml

alex-phillips commented 3 years ago

LGTM