linuxserver / docker-netbox

GNU General Public License v3.0
79 stars 17 forks source link

Expose SSL setting for Redis (e.g. for running in public cloud environments) #35

Closed sopelt closed 1 year ago

sopelt commented 2 years ago

linuxserver.io

Currently docker-netbox has configuration for redis host, password, port ... but does not have something along the lines of REDIS_SSL that enables SSL when connection to external redis instances, that require/enforce secure connections (e.g. running redis as a service on public clouds).


Desired Behavior

Setting -e REDIS_SSL=True should enable SSL when connecting to Redis.

Current Behavior

There is no such option.

Alternatives Considered

sopelt commented 2 years ago

I could look at providing a PR for this if it helps/is welcomed.

github-actions[bot] commented 2 years ago

Thanks for opening your first issue here! Be sure to follow the bug or feature issue templates!

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

drizuid commented 1 year ago

Sorry for such a delay in getting back to you. While we understand the desire to add this and the necessity in certain circumstances, our goal is to keep things as simple as possible (from a readme and envvar perspective) for the majority of users, which unfortunately is a group that doesn't understand ssl/tls or what is involved in it.

With the limited set of users wanting this (you're the only one to ever request it, though I'm sure others would make use of it) I think it is best that you manually edit the file to enable ssl. At this time, we have no plans to add this in or entertain a PR that would do so. If you would like to discuss it further, please jump in our discord and we're open to discussing though we still may not implement this change.