sync nginx conf with upstream nextcloud docs

linuxserver / docker-nextcloud

GNU General Public License v3.0

678 stars 128 forks source link

sync nginx conf with upstream nextcloud docs #392

Closed calvin-li-developer closed 6 months ago

calvin-li-developer commented 6 months ago

[ ✔️ ] I have read the contributing guideline and understand that I have made the correct modifications

Description:

Updates site default conf to upstream configurations.

Benefits of this PR and context:

closes #391 and #388

How Has This Been Tested?

I have done it manually in my nextcloud instance and it seems to fix a log-reader issue and activities tab issue.

Source / References:

https://docs.nextcloud.com/server/latest/admin_manual/installation/nginx.html

LinuxServer-CI commented 6 months ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/nextcloud/28.0.0-pkg-86e5344c-dev-1a559c989305f1c8658b7234019133d9f557ca03-pr-392/index.html https://ci-tests.linuxserver.io/lspipepr/nextcloud/28.0.0-pkg-86e5344c-dev-1a559c989305f1c8658b7234019133d9f557ca03-pr-392/shellcheck-result.xml	Tag	Passed
amd64-28.0.0-pkg-86e5344c-dev-1a559c989305f1c8658b7234019133d9f557ca03-pr-392	✅
arm64v8-28.0.0-pkg-86e5344c-dev-1a559c989305f1c8658b7234019133d9f557ca03-pr-392	✅

LinuxServer-CI commented 6 months ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/nextcloud/28.0.0-pkg-86e5344c-dev-5abf9b3d36c2a6d01e9f202da98eee818d76defc-pr-392/index.html https://ci-tests.linuxserver.io/lspipepr/nextcloud/28.0.0-pkg-86e5344c-dev-5abf9b3d36c2a6d01e9f202da98eee818d76defc-pr-392/shellcheck-result.xml	Tag	Passed
amd64-28.0.0-pkg-86e5344c-dev-5abf9b3d36c2a6d01e9f202da98eee818d76defc-pr-392	✅
arm64v8-28.0.0-pkg-86e5344c-dev-5abf9b3d36c2a6d01e9f202da98eee818d76defc-pr-392	✅

thespad commented 6 months ago

Please revert the fastcgi_pass/php-handler change as it would diverge from our other containers unnecessarily, but otherwise looks good and I'm happy to approve it.

calvin-li-developer commented 6 months ago

Please revert the fastcgi_pass/php-handler change as it would diverge from our other containers unnecessarily, but otherwise looks good and I'm happy to approve it.

done.

LinuxServer-CI commented 6 months ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/nextcloud/28.0.0-pkg-86e5344c-dev-07a04516b1667d2c879ae581663d73b79b25a65e-pr-392/index.html https://ci-tests.linuxserver.io/lspipepr/nextcloud/28.0.0-pkg-86e5344c-dev-07a04516b1667d2c879ae581663d73b79b25a65e-pr-392/shellcheck-result.xml	Tag	Passed
amd64-28.0.0-pkg-86e5344c-dev-07a04516b1667d2c879ae581663d73b79b25a65e-pr-392	✅
arm64v8-28.0.0-pkg-86e5344c-dev-07a04516b1667d2c879ae581663d73b79b25a65e-pr-392	✅

aptalca commented 6 months ago

Version header is duplicate

calvin-li-developer commented 6 months ago

Version header is duplicate

ops forgot to delete the previous line. haha. I think @thespad fixed it. Thanks! 😊