search

linuxserver / docker-nginx

GNU General Public License v3.0
148 stars 46 forks source link

add geoip2 #59

Closed machsix closed 4 years ago

machsix commented 4 years ago

linuxserver.io

We welcome all PR’s though this doesn’t guarantee it will be accepted.

Description:

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

LinuxServer-CI commented 4 years ago

I am a bot, here are the test results for this PR: https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/nginx/09dc1168-pkg-09dc1168-pr-59/index.html https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/nginx/09dc1168-pkg-09dc1168-pr-59/shellcheck-result.xml

LinuxServer-CI commented 4 years ago

I am a bot, here are the test results for this PR: https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/nginx/09dc1168-pkg-09dc1168-pr-59/index.html https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/nginx/09dc1168-pkg-09dc1168-pr-59/shellcheck-result.xml

aptalca commented 4 years ago

Thanks for the PR. Just a heads up, Maxminddb is no longer able to download the db without a user api key. So out of the box it no longer works on alpine.

For the letsencrypt image, we had to do this: https://github.com/linuxserver/docker-letsencrypt/blob/master/root/etc/cont-init.d/50-config#L265-L272

machsix commented 4 years ago

Yes. But I don't know where to modify the upstream Dockerfile. It's better to include something similar. There are some third-party providers syncing the database like

  1. https://geolite.clash.dev/
  2. https://github.com/Dreamacro/maxmind-geoip
aptalca commented 4 years ago

Hmm, it's likely they may get hit with legal requests to take them down since they are redistributing licensed material. MaxMind is a for profit company with resources.

Keep this open, I'll PR some changes to make it work as long as the user provides the db somehow.

LinuxServer-CI commented 4 years ago

I am a bot, here are the test results for this PR: https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/nginx/450d9087-pkg-450d9087-pr-59/index.html https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/nginx/450d9087-pkg-450d9087-pr-59/shellcheck-result.xml

LinuxServer-CI commented 4 years ago

I am a bot, here are the test results for this PR: https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/nginx/450d9087-pkg-450d9087-pr-59/index.html https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/nginx/450d9087-pkg-450d9087-pr-59/shellcheck-result.xml

LinuxServer-CI commented 4 years ago

I am a bot, here are the test results for this PR: https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/nginx/450d9087-pkg-450d9087-pr-59/index.html https://lsio-ci.ams3.digitaloceanspaces.com/lspipepr/nginx/450d9087-pkg-450d9087-pr-59/shellcheck-result.xml