linuxserver / docker-nzbget

GNU General Public License v3.0
144 stars 84 forks source link

add support for TLS 1.3 #144

Closed ghost closed 2 years ago

ghost commented 2 years ago

linuxserver.io

Change build openssl verion to latest in order to support TLS 1.3



Description:

Change build openssl verion to latest in order to support TLS 1.3

Benefits of this PR and context:

Change build openssl verion to latest in order to support TLS 1.3

How Has This Been Tested?

Docker build successful on my machine.

Source / References:

https://pkgs.alpinelinux.org/package/edge/main/x86/openssl-dev

By the way , i really need the performance of tls1.3 .

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/nzbget/v21.1-pkg-63cc5513-pr-144/index.html https://ci-tests.linuxserver.io/lspipepr/nzbget/v21.1-pkg-63cc5513-pr-144/shellcheck-result.xml

Roxedus commented 2 years ago

It always builds with the latest build of openssl

ghost commented 2 years ago

@Roxedus maybe you should test yourself tls1.3 cihper , anyway , i'll push my image to fit my needs ,thanks anyway

Roxedus commented 2 years ago

The image already has that version, https://github.com/linuxserver/docker-nzbget/blob/master/package_versions.txt#L39

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/nzbget/v21.1-pkg-63cc5513-pr-144/index.html https://ci-tests.linuxserver.io/lspipepr/nzbget/v21.1-pkg-63cc5513-pr-144/shellcheck-result.xml

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/nzbget/v21.1-pkg-63cc5513-pr-144/index.html https://ci-tests.linuxserver.io/lspipepr/nzbget/v21.1-pkg-63cc5513-pr-144/shellcheck-result.xml

Roxedus commented 2 years ago

I did just test fwiw.

# docker pull lscr.io/linuxserver/nzbget
...
Status: Downloaded newer image for lscr.io/linuxserver/nzbget:latest
lscr.io/linuxserver/nzbget:latest
# docker create --name=nzbget --tmpfs /config lscr.io/linuxserver/nzbget
4ab9ab1469a5252cadacb7d64aeb4fa4a17d0e8f8d47ee01b0a439b74fb3957a
# docker inspect -f '{{ index .Config.Labels "build_version" }}' nzbget
Linuxserver.io version:- v21.1-ls109 Build-date:- 2022-03-17T09:41:26+00:00
# docker start nzbget
nzbget
# docker exec -it nzbget bash
root@4ab9ab1469a5:/# openssl ciphers -v | grep -i v1.3
TLS_AES_256_GCM_SHA384  TLSv1.3 Kx=any      Au=any  Enc=AESGCM(256) Mac=AEAD
TLS_CHACHA20_POLY1305_SHA256 TLSv1.3 Kx=any      Au=any  Enc=CHACHA20/POLY1305(256) Mac=AEAD
TLS_AES_128_GCM_SHA256  TLSv1.3 Kx=any      Au=any  Enc=AESGCM(128) Mac=AEAD