linuxserver / docker-projectsend

GNU General Public License v3.0
74 stars 26 forks source link

Docker version is 1070, please update to 1270. #17

Closed profrowe closed 3 years ago

profrowe commented 4 years ago

Expected Behavior

projectsend:latest should pull 1270

Current Behavior

1070 is pulled

Steps to Reproduce

Pull the image

Environment

Using k8s on Docker for Windows

github-actions[bot] commented 4 years ago

Thanks for opening your first issue here! Be sure to follow the issue template!

tobbenb commented 4 years ago

It was released 5 hours ago, so please have a little patience. Looks like we have to trigger this manually.

apiening commented 4 years ago

Hi, I just want to point out that version 1295 has been released in the mean time.

WaffleThief123 commented 3 years ago

Hey Team, Just popping in to ask if there's any update on this. The last couple updates have quite a bit of changes in them, and I'd like to see it added or help in building the new version.

Changelog for ProjectSend
Added support for X-Accel on nginx
Fixed password reset forms returning 403. By @varandinawer
New option: select pagination amount for all administration areas
Fixed pagination on default template. Solution by @mike-miguel
Always check php, mysql and modules requirements to prevent the app from running on unsupported platforms
Fixed: statistics chart for roles 7 and 8
Default template: use global pagination amount
Fixed missing uppercase characters on uploaded files
Fixed typo on activities widget
Added file size on public file download page
Added file description colum on manage files page
Don’t show the directories write permissions warning to clients
Fix CVE-2020-28874 by @varandinawer
Login: removed ajax functionality. Fixes infinite loading during errors. Fixes CVE-2020-28875 (found by @varandinawer)
WaffleThief123 commented 3 years ago

After a brief review, and a test on my side, i had no issues during build when I changed line 62 in Dockerfile to:

    "https://www.projectsend.org/download/387/" && \

to reflect the download link for the latest release.

aptalca commented 3 years ago

We'll have to fix the triggers. We're not fond of manually updating versions due to the large number of images we maintain.

WaffleThief123 commented 3 years ago

We'll have to fix the triggers. We're not fond of manually updating versions due to the large number of images we maintain.

I understand that, It's the same thing for me at work. Let me know if there's anything you need help with.

WaffleThief123 commented 3 years ago

@aptalca I went ahead and reached out to the projectsend team to gauge their feeling on changing the way they do releases ever so slightly so that it makes your life easier in making this happen. https://github.com/projectsend/projectsend/issues/876

aptalca commented 3 years ago

Just looked into it and the trigger is not the issue (they do release zips in github now). But the structure has changed quite a bit. It will need a bunch of work.

kad-wenner commented 3 years ago

We are also facing quite some serious issues with this. Is there an intent to update the Dockerimage at some point? Would help us a LOT.

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

apiening commented 3 years ago

Since the provided release is prone to documented security issues (see https://www.projectsend.org/change-log/), may I suggest to add a warning message in the README.md so that people are aware that this release should bot be used in production (at least not publicly reachable)?

Otherwise this may lead users into a security trap, especially since the image is still automatically rebased / updated which may seem as if the image would still be fully maintained.

Tzzui commented 3 years ago

Hello, are there any plans on updating the docker image to the latest projectsend version in the near future?

Escalion commented 3 years ago

I'm currently working on a PR to update to 1295. See #19

Escalion commented 3 years ago

@aptalca I've fixed this in #19 - would you be able to review please?

layanto commented 3 years ago

Should revert part of this commit https://github.com/linuxserver/docker-projectsend/commit/57f01475f3dee768ebd124ea89638843d795f925 which changed to using static URL to download the zip. Prior to this change, latest release was automatically discovered and downloaded.

BenPicard commented 3 years ago

Any update on that?

deepzone1 commented 3 years ago

+1 on this ! :)

thespad commented 3 years ago

Can anyone interested please give lsiodev/projectsend:version-r1070 a go.

Ignore the version number in the tag, it is built with r1295. I've done some basic testing but I don't have a "real" existing install to test what happens on migration, that everything works as expected, etc.

Obviously please make sure you backup your existing data before trying it as it's a pretty substantial set of changes to the image. Please report any issues in this thread.

PascaleBeier commented 3 years ago

@TheSpad Looks good to me, I did lose all my files though (as expected), but just moving them to the storage folder was enough for a quick fix.

Other than the files the database seems to work

thespad commented 3 years ago

@TheSpad Looks good to me, I did lose all my files though (as expected), but just moving them to the storage folder was enough for a quick fix.

Other than the files the database seems to work

Is that something we could automate, or otherwise mitigate? I don't really want to push a new image that'll break everyone's existing setups if they're auto-updating or just updating without reading the change notes.

PascaleBeier commented 3 years ago

Sadly I can't really assist with that since I'm lacking further insight and time right now. Maybe someone else has any feedback. Otherwise I'd figure something out on the weekend.^

EDIT: I am retarded - need to test uprading again. I did not lose any files, they just expired before at some point. Not helpful at all lmao.