linuxserver / docker-projectsend

GNU General Public License v3.0
74 stars 26 forks source link

Remove pointy brackers around `MAX_UPLOAD` default value #26

Closed RealOrangeOne closed 2 years ago

RealOrangeOne commented 2 years ago

linuxserver.io



Description:

"5000" isn't the description of a placeholder, as "" is. Therefore it shouldn't be in brackets, it's just a default value to be changed (similar to PUID and PGID

Benefits of this PR and context:

It makes it clearer what's a variable or a placeholder

How Has This Been Tested?

Source / References:

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/projectsend/r1420-pkg-0af82562-pr-26/index.html https://ci-tests.linuxserver.io/lspipepr/projectsend/r1420-pkg-0af82562-pr-26/shellcheck-result.xml

aptalca commented 2 years ago

While you're at it, can you also fix the volume paths as well? Just change "<path to data>" to "/path/to/config" and "/path/to/data"

aptalca commented 2 years ago

rox was too quick lol