search

linuxserver / docker-pyload

GNU General Public License v3.0
26 stars 10 forks source link

Update Dockerfile - add send2trash pip package #31

Closed zach-morris closed 2 years ago

zach-morris commented 3 years ago

linuxserver.io

Description:

Add send2trash into pip install list. Without it pyload throws the error:

Send2Trash lib not found

After extracting an archive.

Benefits of this PR and context:

Adding the pip package will remove the error. Fixes #20

How Has This Been Tested?

Tested locally

Source / References:

https://discourse.linuxserver.io/t/pyload-send2trash-lib-not-found/2431

LinuxServer-CI commented 3 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/pyload/96f6fb72-pkg-4e498f0a-pr-31/index.html https://ci-tests.linuxserver.io/lspipepr/pyload/96f6fb72-pkg-4e498f0a-pr-31/shellcheck-result.xml

github-actions[bot] commented 2 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

zach-morris commented 2 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Well, the PR needs to be merged. How do you go about getting linuxserver.ios attention to do that?

zach-morris commented 2 years ago

Pinging @aptalca , @technorabilia, @zetneteork as I see those people have the ability to make commits

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/pyload/1d308316-pkg-74ab5432-pr-31/index.html https://ci-tests.linuxserver.io/lspipepr/pyload/1d308316-pkg-74ab5432-pr-31/shellcheck-result.xml

github-actions[bot] commented 2 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

zach-morris commented 2 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

¯_(ツ)_/¯. oh well. i tried

aptalca commented 2 years ago

Please add it to all arches, in alphabetical order, and add a changelog entry. Thanks

github-actions[bot] commented 2 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.