linuxserver / docker-qbittorrent

GNU General Public License v3.0
1.05k stars 154 forks source link

Fix qbittorrent-cli url causing failure when building docker image #277

Closed snippetsBySam closed 11 months ago

snippetsBySam commented 11 months ago

linuxserver.io



Description:

The most recent releases of qbittorrent-cli (as of today 2023-12-19) are nightly builds and have a slightly different download url, which is causing the docker build process to try and download from a broken url, resulting in build failure. This is also causing the latest builds to fail.

Using the latest example, it's trying to download qbittorrent-cli from:

https://github.com/fedarovich/qbittorrent-cli/releases/download/nightly-v1.8.23349.1/qbt-linux-alpine-x64-ightly-v1.8.23349.1.tar.gz

but the correct url is:

https://github.com/fedarovich/qbittorrent-cli/releases/download/nightly-v1.8.23349.1/qbt-linux-alpine-x64-1.8.23349.1.tar.gz

My change removes all [a-zA-Z] and - characters in the second cli version string so that the resulting URL is correct.

Benefits of this PR and context:

It makes the docker file download qbittorrent-cli from the correct URL and stops the build from failing

How Has This Been Tested?

Locally by modifying the failing dockerfile and re-running it which results in a successful build

NOTE: This only fixes the broken url. There is also the question of should this build be using the nightly version of qbittorrent-cli - but thats a question for the maintainers

Source / References:

LinuxServer-CI commented 11 months ago
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/qbittorrent/4.6.2-r0-pkg-6bc3398e-dev-3baaef15cafd0c747345a592f089d4c6f9e82e62-pr-277/index.html https://ci-tests.linuxserver.io/lspipepr/qbittorrent/4.6.2-r0-pkg-6bc3398e-dev-3baaef15cafd0c747345a592f089d4c6f9e82e62-pr-277/shellcheck-result.xml Tag Passed
amd64-4.6.2-r0-pkg-6bc3398e-dev-3baaef15cafd0c747345a592f089d4c6f9e82e62-pr-277
arm64v8-4.6.2-r0-pkg-6bc3398e-dev-3baaef15cafd0c747345a592f089d4c6f9e82e62-pr-277
nemchik commented 11 months ago

This may be better resolved by only using stable versions of qbit cli. I've raised this internally to discuss.