linuxserver / docker-radarr

GNU General Public License v3.0
640 stars 103 forks source link

/etc/services.d/radarr/run is no longer marked as executable, breaking s6 read-only root #181

Closed Avamander closed 1 year ago

Avamander commented 2 years ago

Note: Quite a few linuxserver containers broke like this relatively recently

Expected Behavior

The file "/root/etc/services.d/radarr/run" is no longer marked executable in the container, configurations utilizing S6_READ_ONLY_ROOT and what mark the root read-only will fail. This is a regression compared to the previous builds.

Current Behavior

The ./run file of the radarr service is rw-rw-r-- instead of rwxrw-r-- causing the following error message:

radarr     | s6-supervise radarr (child): fatal: unable to exec run: Permission denied
radarr     | s6-supervise radarr: warning: unable to spawn ./run - waiting 10 seconds

One chmod in the container fixes that.

Steps to Reproduce

Add the snippet provided below to your compose file.

Similar symptoms or issues:

Environment

OS: Ubuntu 22.04 CPU architecture: arm64 How docker service was installed: Official repos

Command used to create docker container

    read_only: true
    tmpfs:
      - /run:rw,exec
      - /tmp:rw,noexec,nosuid
    environment:
      - "S6_READ_ONLY_ROOT=1"
github-actions[bot] commented 2 years ago

Thanks for opening your first issue here! Be sure to follow the bug or feature issue templates!

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

fexofenadine commented 1 year ago

I've been getting a similar issue with every build (latest, develop or nightly) subsequent to linuxserver/radarr:4.1.0.6175-ls151 . the GUI never loads up after the run script fails:

the errors that show up are:

s6-rc: info: service init-services: starting
s6-rc: info: service init-services successfully started
s6-rc: info: service custom-svc-README.txt: starting
s6-supervise custom-svc-README.txt (child): fatal: unable to exec run: Exec format error
s6-supervise custom-svc-README.txt: warning: unable to spawn ./run - waiting 10 seconds
s6-supervise custom-svc-README.txt (child): fatal: unable to exec run: Exec format error
s6-supervise custom-svc-README.txt: warning: unable to spawn ./run - waiting 10 seconds

the last two warnings will repeat indefinitely. rolling back to 4.1.0.6175-ls151 immediately resolves the issue

Avamander commented 1 year ago

@fexofenadine Run docker exec radarr chmod 744 /var/run/s6/services/radarr/run after you create the container and it'll fix the container with the broken image. Not the prettiest though.

j0nnymoe commented 1 year ago

@fexofenadine this isn't the same issue - you need to delete the readme.txt file in your custom folders in the /config mount.

fexofenadine commented 1 year ago

thanks mate that's got it sorted

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Avamander commented 1 year ago

Unstale.