search

linuxserver / docker-smokeping

GNU General Public License v3.0
347 stars 95 forks source link

tcpping leaks 255 ttl #119

Closed dmascord closed 1 year ago

dmascord commented 3 years ago

linuxserver.io

Expected Behavior

tcpping should show packet loss when ttl is expired:

tcpping -C -x 5 100.100.100.199
100.100.100.199 : - - - - -

Current Behavior

tcpping responds with 255, and smokeping interprets as 255ms

tcpping -C -x 5 100.100.100.199
100.100.100.199 : 255 255 255 255 255

Steps to Reproduce

Configure smokeping to use tcpping Probes

github-actions[bot] commented 3 years ago

Thanks for opening your first issue here! Be sure to follow the bug or feature issue templates!

dmascord commented 3 years ago

I have modified the latest tcpping version to the latest version, which handles this scenario properly, but the newest version depends on traceroute -M, which your busybox version does not yet support.

I have updated tcpping to fallback to tcptraceroute if traceroute does not support -M at https://raw.githubusercontent.com/dmascord/tcpping/add-tcptraceroute-fallback/tcpping

dmascord commented 3 years ago

There is still a problem with the tcptraceroute that is included in this image. It is setting the window size to 0, which seems to have firewalls dropping the packets. traceroute -M tcp works well (but the busybox traceroute doesn't seem to have this option), but tcptraceroute, even with the updated tcpping fails on some destinations for SYN and ACK modes due to the underlyung tcptraceroute issue

dmascord commented 3 years ago

OK, found out why tcptraceroute isn't working properly for some endpoints, which is due to the missing TCP Options.

This has been addressed in https://github.com/mct/tcptraceroute/pull/14

How do we get this updated tcptraceroute and associated tcpping into a smokeping docker image ?

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

dmascord commented 3 years ago

Stale? This is still an issue

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

dmascord commented 2 years ago

OK...

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.