Add TCPPing as a default available probe

DeflateAwning commented 2 years ago

Add "TCPPing" as a probe type to the default "Probes" config.

This tcpping script is available by default during the Dockfile setup, so it makes sense that it is included as a standardly-available probe.

[x] I have read the contributing guideline and understand that I have made the correct modifications

Description:

Added a new probe to the default "Probes" config file (which lives in /data after setup).

Benefits of this PR and context:

This new Probe can be used easily in the Targets config.

How Has This Been Tested?

Tested locally, using endpoints like Google.com and 1.1.1.1.

Source / References:

LinuxServer-CI commented 2 years ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/smokeping/2.7.3-r5-pkg-705f13d4-pr-130/index.html https://ci-tests.linuxserver.io/lspipepr/smokeping/2.7.3-r5-pkg-705f13d4-pr-130/shellcheck-result.xml

github-actions[bot] commented 2 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

DeflateAwning commented 2 years ago

Please merge this pull request!

github-actions[bot] commented 2 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

DeflateAwning commented 2 years ago

Please merge this pull request!

ironicbadger commented 2 years ago

Could you please explain a bit more as to why you want this? What benefits does it provide? Does it need any extra documentation?

DeflateAwning commented 2 years ago

TCPPing is useful for performing outgoing ping tests on networks that block UDP packets, or for pinging devices that don't respond to regular pings but do have open TCP ports.

The benefit it provides is being able to ping TCP ports by default from within this system. It may require extra documentation, but the documentation is mostly already present.

github-actions[bot] commented 2 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

DeflateAwning commented 2 years ago

Please complete this task

github-actions[bot] commented 1 year ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

DeflateAwning commented 1 year ago

I still want this

ironicbadger commented 1 year ago

What extra documentation is required? Would you be so kind as to write it?

Apologies for the delays in replying - I rarely check Github notifications.

DeflateAwning commented 1 year ago

On second thought, I don't think there's any documentation that pertains to this strictly. Let me know if you can think of any! Otherwise, it should be good to merge.

ironicbadger commented 1 year ago

@aptalca @Roxedus are you comfortable with merging this? Looks ok to me.

DeflateAwning commented 1 year ago

Would be great if we could merge this soon! Thanks

LinuxServer-CI commented 1 year ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/smokeping/2.7.3-r9-pkg-dfe9a1e2-pr-130/index.html https://ci-tests.linuxserver.io/lspipepr/smokeping/2.7.3-r9-pkg-dfe9a1e2-pr-130/shellcheck-result.xml

linuxserver / docker-smokeping