Rebase to 3.17, migrate to s6v3, switch to nginx - Githubissues

linuxserver / docker-smokeping

GNU General Public License v3.0

347 stars 95 forks source link

Rebase to 3.17, migrate to s6v3, switch to nginx #136

Closed thespad closed 1 year ago

thespad commented 1 year ago

[x] I have read the contributing guideline and understand that I have made the correct modifications

Description:

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

LinuxServer-CI commented 1 year ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/smokeping/2.7.3-r9-pkg-45053078-pr-136/index.html https://ci-tests.linuxserver.io/lspipepr/smokeping/2.7.3-r9-pkg-45053078-pr-136/shellcheck-result.xml

LinuxServer-CI commented 1 year ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/smokeping/2.7.3-r9-pkg-45053078-pr-136/index.html https://ci-tests.linuxserver.io/lspipepr/smokeping/2.7.3-r9-pkg-45053078-pr-136/shellcheck-result.xml

LinuxServer-CI commented 1 year ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/smokeping/2.7.3-r9-pkg-45053078-pr-136/index.html https://ci-tests.linuxserver.io/lspipepr/smokeping/2.7.3-r9-pkg-45053078-pr-136/shellcheck-result.xml

LinuxServer-CI commented 1 year ago

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/smokeping/2.7.3-r9-pkg-45053078-pr-136/index.html https://ci-tests.linuxserver.io/lspipepr/smokeping/2.7.3-r9-pkg-45053078-pr-136/shellcheck-result.xml

VictorLopess commented 1 year ago

Guys. Is it correct? Why maintain the same tag (2.7.3) in a big change like that?

aptalca commented 1 year ago

2.7.3 is not our tag, it's the upstream version

nemchik commented 1 year ago

Guys. Is it correct? Why maintain the same tag (2.7.3) in a big change like that?

Our images are tagged with the version of the upstream project (smokeping version 2.7.3) and our own build number at the end.

For example: https://github.com/linuxserver/docker-smokeping/releases/tag/2.7.3-r9-ls14 And https://github.com/linuxserver/docker-smokeping/releases/tag/2.7.3-r5-ls13

The r9 vs r5 comes from the Alpine package revision: https://pkgs.alpinelinux.org/package/v3.17/main/x86_64/smokeping And https://pkgs.alpinelinux.org/package/v3.13/main/x86_64/smokeping

Anyway, the important thing is the build number ls13 vs ls14 in this case. We don't do semver, just increase build counter.

thespad commented 1 year ago

Unfortunately Alpine haven't updated the smokeping version in years, it's the same in 3.13 as it is in Edge, so we didn't have any other option.